From: Matthias Brugger <matthias.bgg@gmail.com>
To: Rob Herring <robh@kernel.org>, Seiya Wang <seiya.wang@mediatek.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org, srv_heupstream@mediatek.com,
Crystal Guo <crystal.guo@mediatek.com>
Subject: Re: [PATCH 4/4] dt-binding: mediatek: mt8192: update mtk-wdt document
Date: Fri, 24 Jul 2020 00:02:24 +0200 [thread overview]
Message-ID: <d69d441d-b8c7-f4a4-7ae1-a0012d8001f3@gmail.com> (raw)
In-Reply-To: <20200723212935.GA889594@bogus>
On 23/07/2020 23:29, Rob Herring wrote:
> On Thu, Jul 23, 2020 at 05:07:31PM +0800, Seiya Wang wrote:
>> From: Crystal Guo <crystal.guo@mediatek.com>
>>
>> update mtk-wdt document for MT8192 platform
>>
>> Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
>> ---
>> Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
>> index 4dd36bd3f1ad..d760ca8a630e 100644
>> --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
>> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
>> @@ -12,6 +12,8 @@ Required properties:
>> "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629
>> "mediatek,mt8183-wdt", "mediatek,mt6589-wdt": for MT8183
>> "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516
>> + "mediatek,mt8192-wdt": for MT8192
>> +
>
> So, not compatible with "mediatek,mt6589-wdt"? Is so, perhaps summarize
> what the differences are.
>
Hm, looks to me as if the binding description for mt2712 and mt8183 isn't
correct, as we have a OF data just as we have for mt8192 now. Could you fix this
in a separate patch?
Regards,
Matthias
>>
>> - reg : Specifies base physical address and size of the registers.
>>
>> --
>> 2.14.1
next prev parent reply other threads:[~2020-07-23 22:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 9:07 [PATCH 0/4] Add basic node support for Mediatek MT8192 SoC Seiya Wang
2020-07-23 9:07 ` [PATCH 1/4] arm64: dts: Add Mediatek SoC MT8192 and evaluation board dts and Makefile Seiya Wang
2020-07-23 9:07 ` [PATCH 2/4] dt-bindings: serial: Add compatible for Mediatek MT8192 Seiya Wang
2020-07-23 21:28 ` Rob Herring
2020-07-23 9:07 ` [PATCH 3/4] watchdog: mt8192: add wdt support Seiya Wang
2020-07-23 22:00 ` Matthias Brugger
2020-07-24 7:02 ` Crystal Guo
2020-07-23 9:07 ` [PATCH 4/4] dt-binding: mediatek: mt8192: update mtk-wdt document Seiya Wang
2020-07-23 21:29 ` Rob Herring
2020-07-23 22:02 ` Matthias Brugger [this message]
2020-07-24 6:35 ` Crystal Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d69d441d-b8c7-f4a4-7ae1-a0012d8001f3@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=crystal.guo@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=seiya.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).