From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C83E7C432C0 for ; Wed, 20 Nov 2019 07:10:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9C60022365 for ; Wed, 20 Nov 2019 07:10:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Hf3yJbNl"; dkim=pass (1024-bit key) header.d=amazonses.com header.i=@amazonses.com header.b="Ods+RkV4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727711AbfKTHKT (ORCPT ); Wed, 20 Nov 2019 02:10:19 -0500 Received: from a27-55.smtp-out.us-west-2.amazonses.com ([54.240.27.55]:49122 "EHLO a27-55.smtp-out.us-west-2.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726163AbfKTHKS (ORCPT ); Wed, 20 Nov 2019 02:10:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=zsmsymrwgfyinv5wlfyidntwsjeeldzt; d=codeaurora.org; t=1574233817; h=MIME-Version:Content-Type:Content-Transfer-Encoding:Date:From:To:Cc:Subject:In-Reply-To:References:Message-ID; bh=F01WNto9g2WWU8b2YBdoAU11DBHA2jqNmxMqk4unDsI=; b=Hf3yJbNlBUHgjF+fF6d4qiozih0VD1owUoDpG9J2e+AHnWrzptqnOh59jjYqTE9y 29kg1SVNwOM2VlOLQjx1OjCFrZfUH63bGLBqoDqH+NdYysbRGhSiPU3gQTMW8kmBary W+KFp6az7a9lpOAHhx0zNNiugGOeVUxUxjCXKn40= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx; d=amazonses.com; t=1574233817; h=MIME-Version:Content-Type:Content-Transfer-Encoding:Date:From:To:Cc:Subject:In-Reply-To:References:Message-ID:Feedback-ID; bh=F01WNto9g2WWU8b2YBdoAU11DBHA2jqNmxMqk4unDsI=; b=Ods+RkV4dysBwtH1WlTjTB3ZNzWhAIQPRFcQCWerlbFMJQmWyUYBqHN4NzGtAnPg UNs8pw7lC+j7t8AwQxvZtW2dBSqaBDeQTwGswVkx1/e+zQalNiGqcLVx9WHDMWcxpJV 348InsHar2eMbzNy/MeKkvH2UVJUW60ACYEtu44I= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 20 Nov 2019 07:10:17 +0000 From: wgong@codeaurora.org To: Kalle Valo Cc: Ulf Hansson , Doug Anderson , Linux MMC List , Adrian Hunter , Matthias Kaehlcke , Tony Lindgren , Erik Stromdahl , Eyal Reizer , linux-wireless , Brian Norris , ath10k@lists.infradead.org Subject: Re: [PATCH v2 3/3] mmc: core: Re-work HW reset for SDIO cards In-Reply-To: <87zhgr5af6.fsf@codeaurora.org> References: <20191109103046.26445-1-ulf.hansson@linaro.org> <20191109103046.26445-4-ulf.hansson@linaro.org> <87zhgr5af6.fsf@codeaurora.org> Message-ID: <0101016e87a5c128-49fdb6eb-a17c-4fe9-8ac5-b521ebd0314f-000000@us-west-2.amazonses.com> X-Sender: wgong@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-SES-Outgoing: 2019.11.20-54.240.27.55 Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2019-11-20 14:28, Kalle Valo wrote: > + wen, ath10k > > Ulf Hansson writes: > >> On Tue, 12 Nov 2019 at 01:33, Doug Anderson >> wrote: >>> >>> Hi, >>> >>> On Sat, Nov 9, 2019 at 2:31 AM Ulf Hansson >>> wrote: >>> > >>> > diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c >>> > index 6f8342702c73..abf8f5eb0a1c 100644 >>> > --- a/drivers/mmc/core/core.c >>> > +++ b/drivers/mmc/core/core.c >>> > @@ -1469,8 +1469,7 @@ void mmc_detach_bus(struct mmc_host *host) >>> > mmc_bus_put(host); >>> > } >>> > >>> > -static void _mmc_detect_change(struct mmc_host *host, unsigned long delay, >>> > - bool cd_irq) >>> > +void _mmc_detect_change(struct mmc_host *host, unsigned long delay, bool cd_irq) >>> > { >>> > /* >>> > * If the device is configured as wakeup, we prevent a new sleep for >>> > @@ -2129,7 +2128,7 @@ int mmc_hw_reset(struct mmc_host *host) >>> > ret = host->bus_ops->hw_reset(host); >>> > mmc_bus_put(host); >>> > >>> > - if (ret) >>> > + if (ret < 0) >>> > pr_warn("%s: tried to HW reset card, got error %d\n", >>> > mmc_hostname(host), ret); >>> >>> Other callers besides marvell need to be updated? In theory only >>> SDIO >>> should have positive return values so I guess we don't care about the >>> caller in drivers/mmc/core/block.c, right? >> >> Correct, but maybe I should add some more information about that in a >> function header of mmc_hw_reset(). Let me consider doing that as a >> change on top. >> >>> What about: >>> >>> drivers/net/wireless/ath/ath10k/sdio.c >>> >>> ...I guess I don't know if there is more than one function probed >>> there. Maybe there's not and thus we're fine here too? >> >> Well, honestly I don't know. >> >> In any case, that would mean the driver is broken anyways and needs to >> be fixed. At least that's my approach to doing this change. > > Wen, does QCA6174 or QCA9377 SDIO devices have other SDIO functions, > for > example bluetooth? I'm just wondering how should we handle this in > ath10k. Hi Kalle, it does not have other SDIO functions for QCA6174 or QCA9377.