From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Phong Tran <tranmanphong@gmail.com>,
jakub.kicinski@netronome.com, davem@davemloft.net,
luciano.coelho@intel.com, shahar.s.matityahu@intel.com,
johannes.berg@intel.com, emmanuel.grumbach@intel.com,
sara.sharon@intel.com, yhchuang@realtek.com,
yuehaibing@huawei.com, pkshih@realtek.com,
arend.vanspriel@broadcom.com, rafal@milecki.pl,
franky.lin@broadcom.com, pieter-paul.giesberts@broadcom.com,
p.figiel@camlintechnologies.com, Wright.Feng@cypress.com,
keescook@chromium.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] drivers: net: intel: Fix -Wcast-function-type
Date: Mon, 25 Nov 2019 17:56:03 +0000 [thread overview]
Message-ID: <0101016ea3b4c45e-39ce3a65-7fba-4bf6-a788-ba579c1ea122-000000@us-west-2.amazonses.com> (raw)
In-Reply-To: <61fa4ef5-e4fc-c20c-9e20-158bcdf61cbb@lwfinger.net> (Larry Finger's message of "Mon, 25 Nov 2019 11:30:47 -0600")
Larry Finger <Larry.Finger@lwfinger.net> writes:
> On 11/25/19 9:02 AM, Phong Tran wrote:
>> correct usage prototype of callback in tasklet_init().
>> Report by https://github.com/KSPP/linux/issues/20
>>
>> Signed-off-by: Phong Tran <tranmanphong@gmail.com>
>> ---
>> drivers/net/wireless/intel/ipw2x00/ipw2100.c | 7 ++++---
>> drivers/net/wireless/intel/ipw2x00/ipw2200.c | 5 +++--
>> drivers/net/wireless/intel/iwlegacy/3945-mac.c | 5 +++--
>> drivers/net/wireless/intel/iwlegacy/4965-mac.c | 5 +++--
>> 4 files changed, 13 insertions(+), 9 deletions(-)
>
> This patch is "fixing" three different drivers and should be split
> into at least two parts. To be consistent with previous practices, the
> subject for the two should be "intel: ipw2100: ...." and "intel:
> iwlegacy: ...."
Actually, please drop even "intel:". So "ipw2x00: " and "iwlegacy: " is
enough.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-11-25 17:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 15:02 [PATCH 1/3] drivers: net: b43legacy: Fix -Wcast-function-type Phong Tran
2019-11-25 15:02 ` [PATCH 2/3] drivers: net: intel: " Phong Tran
2019-11-25 17:30 ` Larry Finger
2019-11-25 17:56 ` Kalle Valo [this message]
2019-11-25 15:02 ` [PATCH 3/3] drivers: net: realtek: " Phong Tran
2019-11-25 17:33 ` Larry Finger
2019-11-25 17:26 ` [PATCH 1/3] drivers: net: b43legacy: " Larry Finger
2019-11-25 17:28 ` Jakub Kicinski
2019-11-25 17:29 ` Kalle Valo
2019-11-26 17:55 ` [Patch v2 0/4] wireless: " Phong Tran
2019-11-26 17:55 ` [Patch v2 1/4] b43legacy: " Phong Tran
2019-11-27 5:05 ` Kees Cook
2019-12-18 18:55 ` Kalle Valo
2019-11-26 17:55 ` [Patch v2 2/4] ipw2x00: " Phong Tran
2019-11-27 5:05 ` Kees Cook
2019-11-26 17:55 ` [Patch v2 3/4] iwlegacy: " Phong Tran
2019-11-27 5:05 ` Kees Cook
2019-11-26 17:55 ` [Patch v2 4/4] rtlwifi: rtl_pci: " Phong Tran
2019-11-27 5:05 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0101016ea3b4c45e-39ce3a65-7fba-4bf6-a788-ba579c1ea122-000000@us-west-2.amazonses.com \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=Wright.Feng@cypress.com \
--cc=arend.vanspriel@broadcom.com \
--cc=davem@davemloft.net \
--cc=emmanuel.grumbach@intel.com \
--cc=franky.lin@broadcom.com \
--cc=jakub.kicinski@netronome.com \
--cc=johannes.berg@intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
--cc=p.figiel@camlintechnologies.com \
--cc=pieter-paul.giesberts@broadcom.com \
--cc=pkshih@realtek.com \
--cc=rafal@milecki.pl \
--cc=sara.sharon@intel.com \
--cc=shahar.s.matityahu@intel.com \
--cc=tranmanphong@gmail.com \
--cc=yhchuang@realtek.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).