linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Zhu Yi <yi.zhu@intel.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] cfg80211: set SME state machine correctly for roam event
Date: Thu, 13 Aug 2009 11:54:09 +0200	[thread overview]
Message-ID: <1250157249.21250.0.camel@johannes.local> (raw)
In-Reply-To: <1250155399-17847-1-git-send-email-yi.zhu@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]

On Thu, 2009-08-13 at 17:23 +0800, Zhu Yi wrote:
> When we receive a successful status in CFG80211_SME_CONNECTED state,
> it is a roam event. We should mark it as a success result.

But there's a cfg80211_roamed() call for that? Can the driver not tell
the difference? It also sends a different event (ROAMED rather than
CONNECTED) to userspace.

johannes

> Cc: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Zhu Yi <yi.zhu@intel.com>
> ---
>  net/wireless/sme.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/net/wireless/sme.c b/net/wireless/sme.c
> index 8e2ef54..1aa1190 100644
> --- a/net/wireless/sme.c
> +++ b/net/wireless/sme.c
> @@ -393,7 +393,8 @@ void __cfg80211_connect_result(struct net_device *dev, const u8 *bssid,
>  	}
>  
>  	if (status == WLAN_STATUS_SUCCESS &&
> -	    wdev->sme_state == CFG80211_SME_IDLE)
> +	    (wdev->sme_state == CFG80211_SME_IDLE ||
> +	     wdev->sme_state == CFG80211_SME_CONNECTED))
>  		goto success;
>  
>  	if (wdev->sme_state != CFG80211_SME_CONNECTING)


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

  reply	other threads:[~2009-08-13  9:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-13  9:23 [PATCH] cfg80211: set SME state machine correctly for roam event Zhu Yi
2009-08-13  9:54 ` Johannes Berg [this message]
2009-08-14  3:58   ` Zhu Yi
2009-08-14 14:54     ` Johannes Berg
2009-08-17  2:35       ` Zhu Yi
2009-08-17  7:23         ` Johannes Berg
2009-08-14 16:05   ` Jussi Kivilinna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1250157249.21250.0.camel@johannes.local \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).