From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
lrodriguez@atheros.com
Subject: Re: [PATCH 7/9] mac80211: add flags for STBC (Space-Time Block Coding)
Date: Mon, 19 Apr 2010 11:09:10 +0200 [thread overview]
Message-ID: <1271668150.3873.17.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4BCC1D1A.7020705@openwrt.org>
On Mon, 2010-04-19 at 11:06 +0200, Felix Fietkau wrote:
> On 2010-04-19 10:59 AM, Johannes Berg wrote:
> > On Mon, 2010-04-19 at 10:45 +0200, Felix Fietkau wrote:
> >> On 2010-04-19 7:57 AM, Johannes Berg wrote:
> >> > On Sun, 2010-04-18 at 18:05 +0200, Felix Fietkau wrote:
> >> >
> >> >> >> + * @IEEE80211_TX_CTL_STBC: tells the driver to use Space-Time Block Coding
> >> >> >> + * (STBC) for this frame.
> >> >> >> */
> >> >> >> enum mac80211_tx_control_flags {
> >> >> >> IEEE80211_TX_CTL_REQ_TX_STATUS = BIT(0),
> >> >> >> @@ -299,6 +301,7 @@ enum mac80211_tx_control_flags {
> >> >> >> IEEE80211_TX_INTFL_HAS_RADIOTAP = BIT(20),
> >> >> >> IEEE80211_TX_INTFL_NL80211_FRAME_TX = BIT(21),
> >> >> >> IEEE80211_TX_CTL_LDPC = BIT(22),
> >> >> >> + IEEE80211_TX_CTL_STBC = BIT(23),
> >> >> >
> >> >> > What if the # of streams is different? That doesn't look sufficient.
> >> >
> >> >> Hm, you're right. I initially thought the combination of the MCS index
> >> >> and the STBC flag would be enough, but there are still some corner cases.
> >> >
> >> > Hm actually I guess that should be sufficient? What corner case are you
> >> > thinking of?
> >> Support for multi-rate retry and STBC with more than one stream on one
> >> side, using rates from both MCS0-7 and MCS8-15 in the rate series.
> >> Rx STBC for only one stream on the other side.
> >
> > So the flag should be per rate entry instead, no?
> Well, I think if we use two bits in the tx control flags, we don't need
> it to be per rate entry.
But then you can't probe stbc properly, can you?
> We don't have any space left for more per rate entry flags ;)
separate problem ;)
johannes
next prev parent reply other threads:[~2010-04-19 9:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-18 14:56 [PATCH 1/9] ath9k: check for specific rx stuck conditions and recover from them Felix Fietkau
2010-04-18 14:56 ` [PATCH 2/9] ath9k: clean up tx buffer handling Felix Fietkau
2010-04-18 14:56 ` [PATCH 3/9] ath9k: update the MCS mask for MCS16 and above Felix Fietkau
2010-04-18 14:56 ` [PATCH 4/9] ath9k: update the ath_max_4ms_framelen table Felix Fietkau
2010-04-18 14:56 ` [PATCH 5/9] ath9k: reduce the bits_per_symbol table size, support more streams Felix Fietkau
2010-04-18 14:56 ` [PATCH 6/9] ath9k: initialize the number of tx/rx streams correctly Felix Fietkau
2010-04-18 14:56 ` [PATCH 7/9] mac80211: add flags for STBC (Space-Time Block Coding) Felix Fietkau
2010-04-18 14:56 ` [PATCH 8/9] ath9k: add support for Tx and Rx STBC Felix Fietkau
2010-04-18 14:56 ` [PATCH 9/9] ath9k: set the STBC flag in rate control if the peer supports it Felix Fietkau
2010-04-19 12:22 ` [PATCH 8/9] ath9k: add support for Tx and Rx STBC Björn Smedman
2010-04-19 12:28 ` Felix Fietkau
2010-04-18 15:53 ` [PATCH 7/9] mac80211: add flags for STBC (Space-Time Block Coding) Johannes Berg
2010-04-18 16:05 ` Felix Fietkau
2010-04-19 5:57 ` Johannes Berg
2010-04-19 8:45 ` Felix Fietkau
2010-04-19 8:59 ` Johannes Berg
2010-04-19 9:06 ` Felix Fietkau
2010-04-19 9:09 ` Johannes Berg [this message]
2010-04-19 10:14 ` Felix Fietkau
2010-04-19 10:19 ` Johannes Berg
2010-04-19 10:51 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271668150.3873.17.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).