From: Stephen Boyd <swboyd@chromium.org>
To: Govind Singh <govinds@codeaurora.org>,
andy.gross@linaro.org, ath10k@lists.infradead.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-soc@vger.kernel.org, linux-wireless@vger.kernel.org,
robh+dt@kernel.org
Cc: Govind Singh <govinds@codeaurora.org>
Subject: Re: [PATCH v3 2/3] dts: arm64/sdm845: Add WCN3990 WLAN module device node
Date: Wed, 17 Oct 2018 00:33:48 -0700 [thread overview]
Message-ID: <153976162862.5275.4810472671573539341@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1539172376-19269-3-git-send-email-govinds@codeaurora.org>
Quoting Govind Singh (2018-10-10 04:52:55)
> @@ -1403,5 +1408,26 @@
> status = "disabled";
> };
> };
> +
> + wifi: wifi@18800000 {
> + compatible = "qcom,wcn3990-wifi";
> + status = "disabled";
> + reg = <0x18800000 0x800000>;
> + reg-names = "membase";
> + memory-region = <&wlan_msa_mem>;
> + interrupts =
> + <0 413 0 /* CE0 */ >,
Please specify these as GIC_SPI and give trigger types (level high I
guess?). I'd also drop the comment and add interrupt-names to match the
comment. It's self documenting that way.
> + <0 414 0 /* CE1 */ >,
> + <0 415 0 /* CE2 */ >,
> + <0 416 0 /* CE3 */ >,
> + <0 417 0 /* CE4 */ >,
> + <0 418 0 /* CE5 */ >,
> + <0 420 0 /* CE6 */ >,
> + <0 421 0 /* CE7 */ >,
> + <0 422 0 /* CE8 */ >,
> + <0 423 0 /* CE9 */ >,
> + <0 424 0 /* CE10 */ >,
> + <0 425 0 /* CE11 */ >;
next prev parent reply other threads:[~2018-10-17 7:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 11:52 [PATCH v3 0/3] Enable ath10k wcn3990 wifi driver support on sdm845 Govind Singh
2018-10-10 11:52 ` [PATCH v3 1/3] dt: bindings: add missing dt properties for WCN3990 wifi node Govind Singh
2018-10-12 16:18 ` Rob Herring
2018-10-16 22:53 ` Doug Anderson
2018-10-30 12:40 ` Govind Singh
2018-10-17 7:41 ` Stephen Boyd
2018-11-02 18:43 ` Brian Norris
2018-11-05 16:33 ` Stephen Boyd
2018-11-07 0:07 ` Brian Norris
2018-11-07 2:58 ` Brian Norris
2018-10-10 11:52 ` [PATCH v3 2/3] dts: arm64/sdm845: Add WCN3990 WLAN module device node Govind Singh
2018-10-16 21:45 ` Doug Anderson
2018-10-17 7:33 ` Stephen Boyd [this message]
2018-10-10 11:52 ` [PATCH v3 3/3] dt: bindings: add bindings for wifi iommu node Govind Singh
2018-10-12 16:19 ` Rob Herring
2018-10-12 23:02 ` [PATCH v3 0/3] Enable ath10k wcn3990 wifi driver support on sdm845 Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153976162862.5275.4810472671573539341@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=andy.gross@linaro.org \
--cc=ath10k@lists.infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=govinds@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).