From: Denis Kenzior <denkenz@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>,
James Prestwood <prestwoj@gmail.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: Support LIVE_ADDRESS_CHANGE feature
Date: Tue, 8 Oct 2019 13:50:55 -0500 [thread overview]
Message-ID: <193168d4-6466-60a4-bc89-c4a44e84ac46@gmail.com> (raw)
In-Reply-To: <fbb287a82656dd3f89817590e86b23d6968a2822.camel@sipsolutions.net>
Hi Johannes,
>> But they shouldn't change due a mac address change? I wonder if we can
>> further relax the requirements to allow mac change if
>> NL80211_SCAN_FLAG_RANDOM_ADDR was used?
>
> No, at least with HW scan that would completely confuse the driver -
> since from the driver's POV we'd remove the interface it's currently
> managing the scan for.
So help me understand this better. Just by virtue of copying the new
mac into sdata->vif.addr we'd be confusing the driver such that it can't
associate the ongoing scan request to the wdev it was started on? Even
when it has all this info? I mean you have a single scan request on a
phy, how hard can this be? :)
Note that some apps perform poor-man's scan address randomization by
varying the mac (I assume prior to each nth scan). So being able to
change the mac while scanning might be a boon to them. I personally
don't think changing mac via rtnl to accomplish this is a great idea,
but just tossing it out for you.
Regards,
-Denis
next prev parent reply other threads:[~2019-10-08 18:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 19:59 [PATCH 1/2] nl80211: Add LIVE_ADDR_CHANGE feature James Prestwood
2019-09-13 19:59 ` [PATCH 2/2] mac80211: Support LIVE_ADDRESS_CHANGE feature James Prestwood
2019-10-04 11:56 ` Johannes Berg
2019-10-04 16:25 ` James Prestwood
2019-10-04 16:42 ` James Prestwood
2019-10-07 21:16 ` Johannes Berg
2019-10-08 15:37 ` Denis Kenzior
2019-10-08 15:52 ` Johannes Berg
2019-10-08 15:53 ` Denis Kenzior
2019-10-08 16:24 ` Johannes Berg
2019-10-08 16:23 ` Denis Kenzior
2019-10-08 17:08 ` Johannes Berg
2019-10-08 18:50 ` Denis Kenzior [this message]
2019-10-08 20:16 ` Johannes Berg
2019-10-08 20:55 ` Denis Kenzior
2019-10-10 15:18 ` Johannes Berg
2019-10-07 21:11 ` Johannes Berg
2019-10-08 15:28 ` Denis Kenzior
2019-10-08 15:49 ` Johannes Berg
2019-09-13 20:48 ` [PATCH 1/2] nl80211: Add LIVE_ADDR_CHANGE feature Johannes Berg
2019-09-13 20:56 ` James Prestwood
2019-09-13 21:01 ` Johannes Berg
2019-09-13 21:14 ` James Prestwood
2019-09-17 20:09 ` James Prestwood
2019-10-01 9:14 ` Johannes Berg
2019-10-08 22:13 ` James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=193168d4-6466-60a4-bc89-c4a44e84ac46@gmail.com \
--to=denkenz@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=prestwoj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).