From: Michael Buesch <mb@bu3sch.de>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: Daniel Mack <daniel@caiaq.de>,
"John W. Linville" <linville@tuxdriver.com>,
libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Libertas: Association request to the driver failed
Date: Sun, 9 Aug 2009 13:10:56 +0200 [thread overview]
Message-ID: <200908091310.56919.mb@bu3sch.de> (raw)
In-Reply-To: <4A7EAED8.9090900@gmail.com>
On Sunday 09 August 2009 13:11:20 Roel Kluin wrote:
> @@ -43,21 +44,21 @@ static int get_common_rates(struct lbs_private *priv,
> u16 *rates_size)
> {
> u8 *card_rates = lbs_bg_rates;
> - size_t num_card_rates = sizeof(lbs_bg_rates);
> int ret = 0, i, j;
> - u8 tmp[30];
> + u8 tmp[*rates_size * ARRAY_SIZE(lbs_bg_rates)];
Is it a good idea to use dynamic stack arrays in the kernel?
What about kmalloc for dynamic allocations?
--
Greetings, Michael.
next prev parent reply other threads:[~2009-08-09 11:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-07 19:11 Libertas: Association request to the driver failed Daniel Mack
2009-08-07 19:36 ` John W. Linville
2009-08-07 20:50 ` Marek Vasut
2009-08-08 12:35 ` Daniel Mack
2009-08-08 14:24 ` Roel Kluin
2009-08-09 9:23 ` Roel Kluin
2009-08-09 10:24 ` Daniel Mack
2009-08-09 11:11 ` Roel Kluin
2009-08-09 11:10 ` Michael Buesch [this message]
2009-08-09 19:13 ` Cyrill Gorcunov
2009-08-10 10:37 ` Roel Kluin
2009-08-10 14:04 ` Cyrill Gorcunov
2009-08-10 17:47 ` Daniel Mack
2009-08-12 8:17 ` Jonathan Cameron
2009-08-12 8:47 ` Jonathan Cameron
2009-08-12 16:16 ` Dan Williams
2009-08-10 17:59 ` John W. Linville
2009-08-11 7:02 ` Roel Kluin
2009-08-11 18:24 ` John W. Linville
2009-08-12 16:15 ` Dan Williams
2009-08-12 17:34 ` Dan Williams
2009-08-07 21:21 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908091310.56919.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=daniel@caiaq.de \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).