From: Markus Trippelsdorf <markus@trippelsdorf.de>
To: Jens Axboe <jaxboe@fusionio.com>
Cc: Tejun Heo <htejun@gmail.com>, "Rafael J. Wysocki" <rjw@sisk.pl>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Maciej Rutecki <maciej.rutecki@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kernel Testers List <kernel-testers@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
Linux PM List <linux-pm@lists.linux-foundation.org>,
Linux SCSI List <linux-scsi@vger.kernel.org>,
Linux Wireless List <linux-wireless@vger.kernel.org>,
DRI <dri-devel@lists.freedesktop.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
"stable@kernel.org" <stable@kernel.org>
Subject: Re: [PATCH RESEND block#for-2.6.36] block_dev: always serialize exclusive open attempts
Date: Thu, 5 Aug 2010 11:17:04 +0200 [thread overview]
Message-ID: <20100805091704.GA1772@arch.tripp.de> (raw)
In-Reply-To: <4C5A7E33.3060101@fusionio.com>
On Thu, Aug 05, 2010 at 11:02:43AM +0200, Jens Axboe wrote:
> On 2010-08-04 17:59, Tejun Heo wrote:
> > bd_prepare_to_claim() incorrectly allowed multiple attempts for
> > exclusive open to progress in parallel if the attempting holders are
> > identical. This triggered BUG_ON() as reported in the following bug.
> >
> > https://bugzilla.kernel.org/show_bug.cgi?id=16393
> >
> > __bd_abort_claiming() is used to finish claiming blocks and doesn't
> > work if multiple openers are inside a claiming block. Allowing
> > multiple parallel open attempts to continue doesn't gain anything as
> > those are serialized down in the call chain anyway. Fix it by always
> > allowing only single open attempt in a claiming block.
> >
> > This problem can easily be reproduced by adding a delay after
> > bd_prepare_to_claim() and attempting to mount two partitions of a
> > disk.
> >
> > stable: only applicable to v2.6.35
> >
> > Signed-off-by: Tejun Heo <tj@kernel.org>
> > Reported-by: Markus Trippelsdorf <markus@trippelsdorf.de>
> > Cc: stable@kernel.org
>
> Thanks Tejun, applied.
It's already in mainline:
e75aa85892b2ee78c79edac720868cbef16e62eb
--
»A man who doesn't know he is in prison can never escape.«
William S. Burroughs
next prev parent reply other threads:[~2010-08-05 9:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-01 13:46 2.6.35-rc6-git6: Reported regressions from 2.6.34 Rafael J. Wysocki
2010-08-01 18:01 ` Linus Torvalds
2010-08-01 21:37 ` Rafael J. Wysocki
2010-08-02 16:32 ` Tejun Heo
2010-08-04 15:40 ` [PATCH block#for-2.6.36] block_dev: always serialize exclusive open attempts Tejun Heo
2010-08-04 15:59 ` [PATCH RESEND " Tejun Heo
2010-08-05 9:02 ` Jens Axboe
2010-08-05 9:17 ` Markus Trippelsdorf [this message]
2010-08-05 9:20 ` Jens Axboe
2010-08-01 19:39 ` 2.6.35-rc6-git6: Reported regressions from 2.6.34 Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100805091704.GA1772@arch.tripp.de \
--to=markus@trippelsdorf.de \
--cc=akpm@linux-foundation.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=htejun@gmail.com \
--cc=jaxboe@fusionio.com \
--cc=kernel-testers@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=maciej.rutecki@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).