From: Kalle Valo <kvalo@codeaurora.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
"David S. Miller" <davem@davemloft.net>,
Arnd Bergmann <arnd@arndb.de>,
Simon Wunderlich <sw@simonwunderlich.de>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ath9k: fix RX_STAT_INC() etc macros
Date: Sat, 13 Oct 2018 17:28:10 +0000 (UTC) [thread overview]
Message-ID: <20181013172810.A856160B72@smtp.codeaurora.org> (raw)
In-Reply-To: <20181009160351.680666-1-arnd@arndb.de>
Arnd Bergmann <arnd@arndb.de> wrote:
> A couple of macros that deal with statistics in ath9k rely on the
> declaration of the 'sc' variable, which they dereference.
>
> However, when the statistics are disabled, the new instance in
> ath_cmn_process_fft() causes a warning for an unused variable:
>
> drivers/net/wireless/ath/ath9k/common-spectral.c: In function 'ath_cmn_process_fft':
> drivers/net/wireless/ath/ath9k/common-spectral.c:474:20: error: unused variable 'sc' [-Werror=unused-variable]
>
> It's better if those macros only operate on their arguments instead of
> known variable names, and adding a cast to (void) kills off that warning.
>
> Fixes: 03224678c013 ("ath9k: add counters for good and errorneous FFT/spectral frames")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
72569b7be461 ath9k: fix RX_STAT_INC() etc macros
--
https://patchwork.kernel.org/patch/10632911/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2018-10-13 17:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 16:03 [PATCH] ath9k: fix RX_STAT_INC() etc macros Arnd Bergmann
2018-10-13 17:28 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181013172810.A856160B72@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arnd@arndb.de \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).