From: kbuild test robot <lkp@intel.com>
To: Jouni Malinen <jouni@codeaurora.org>
Cc: kbuild-all@01.org, Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org,
Jouni Malinen <jouni@codeaurora.org>
Subject: Re: [PATCH 5/5] mac80211_hwsim: Declare support for Multi-BSSID
Date: Wed, 19 Dec 2018 20:16:31 +0800 [thread overview]
Message-ID: <201812192019.1XGrI9ll%fengguang.wu@intel.com> (raw)
In-Reply-To: <1544184650-14124-5-git-send-email-jouni@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 3637 bytes --]
Hi Jouni,
I love your patch! Perhaps something to improve:
[auto build test WARNING on mac80211-next/master]
[also build test WARNING on v4.20-rc7 next-20181218]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Jouni-Malinen/cfg80211-Parsing-of-Multiple-BSSID-information-in-scanning/20181208-040803
base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
include/linux/slab.h:332:43: warning: dubious: x & !y
include/linux/slab.h:332:43: warning: dubious: x & !y
include/linux/slab.h:332:43: warning: dubious: x & !y
include/linux/slab.h:332:43: warning: dubious: x & !y
include/linux/slab.h:332:43: warning: dubious: x & !y
include/linux/slab.h:332:43: warning: dubious: x & !y
include/linux/slab.h:332:43: warning: dubious: x & !y
include/linux/slab.h:332:43: warning: dubious: x & !y
>> net/wireless/scan.c:319:1: warning: context imbalance in 'cfg80211_add_nontrans_list' - different lock contexts for basic block
>> net/wireless/scan.c:1543:1: warning: context imbalance in 'cfg80211_update_notlisted_nontrans' - different lock contexts for basic block
vim +/cfg80211_add_nontrans_list +319 net/wireless/scan.c
bad457b4 Peng Xu 2018-12-07 317
bad457b4 Peng Xu 2018-12-07 318 static int
6ff7973a Sara Sharon 2018-12-07 @319 cfg80211_add_nontrans_list(struct cfg80211_bss *trans_bss,
6ff7973a Sara Sharon 2018-12-07 320 struct cfg80211_bss *nontrans_bss)
bad457b4 Peng Xu 2018-12-07 321 {
bad457b4 Peng Xu 2018-12-07 322 const u8 *ssid;
bad457b4 Peng Xu 2018-12-07 323 size_t ssid_len;
6ff7973a Sara Sharon 2018-12-07 324 struct cfg80211_bss *bss = NULL;
bad457b4 Peng Xu 2018-12-07 325
bad457b4 Peng Xu 2018-12-07 326 rcu_read_lock();
6ff7973a Sara Sharon 2018-12-07 327 ssid = ieee80211_bss_get_ie(nontrans_bss, WLAN_EID_SSID);
bad457b4 Peng Xu 2018-12-07 328 if (!ssid)
bad457b4 Peng Xu 2018-12-07 329 return -EINVAL;
bad457b4 Peng Xu 2018-12-07 330 ssid_len = ssid[1];
bad457b4 Peng Xu 2018-12-07 331 ssid = ssid + 2;
bad457b4 Peng Xu 2018-12-07 332 rcu_read_unlock();
bad457b4 Peng Xu 2018-12-07 333
bad457b4 Peng Xu 2018-12-07 334 /* check if nontrans_bss is in the list */
bad457b4 Peng Xu 2018-12-07 335 list_for_each_entry(bss, &trans_bss->nontrans_list, nontrans_list) {
6ff7973a Sara Sharon 2018-12-07 336 if (is_bss(bss, nontrans_bss->bssid, ssid, ssid_len))
bad457b4 Peng Xu 2018-12-07 337 return 0;
bad457b4 Peng Xu 2018-12-07 338 }
bad457b4 Peng Xu 2018-12-07 339
bad457b4 Peng Xu 2018-12-07 340 /* add to the list */
bad457b4 Peng Xu 2018-12-07 341 list_add_tail(&nontrans_bss->nontrans_list, &trans_bss->nontrans_list);
bad457b4 Peng Xu 2018-12-07 342 return 0;
bad457b4 Peng Xu 2018-12-07 343 }
bad457b4 Peng Xu 2018-12-07 344
:::::: The code at line 319 was first introduced by commit
:::::: 6ff7973a64687877f58afbbf55036c096b75c6ea cfg80211: Move Multiple BSS info to struct cfg80211_bss to be visible
:::::: TO: Sara Sharon <sara.sharon@intel.com>
:::::: CC: 0day robot <lkp@intel.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 66574 bytes --]
prev parent reply other threads:[~2018-12-19 12:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 12:10 [PATCH 1/5] cfg80211: Parsing of Multiple BSSID information in scanning Jouni Malinen
2018-12-07 12:10 ` [PATCH 2/5] cfg80211: Properly track transmitting and non-transmitting BSS Jouni Malinen
2018-12-07 21:10 ` kbuild test robot
2018-12-07 12:10 ` [PATCH 3/5] cfg80211: Move Multiple BSS info to struct cfg80211_bss to be visible Jouni Malinen
2018-12-09 9:12 ` kbuild test robot
2018-12-07 12:10 ` [PATCH 4/5] mac80211: Declare support for Multi-BSSID if driver supports it Jouni Malinen
2018-12-07 12:10 ` [PATCH 5/5] mac80211_hwsim: Declare support for Multi-BSSID Jouni Malinen
2018-12-19 12:16 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201812192019.1XGrI9ll%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=johannes@sipsolutions.net \
--cc=jouni@codeaurora.org \
--cc=kbuild-all@01.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).