From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: linux-wireless@vger.kernel.org,
"Randy Oostdyk" <linux-kernel@oostdyk.com>,
"Tomislav Požega" <pozega.tomislav@gmail.com>,
"Daniel Golle" <daniel@makrotopia.org>,
"Felix Fietkau" <nbd@nbd.name>, "Mathias Kresin" <dev@kresin.me>
Subject: Re: [PATCH v2 1/3] rt2x00: use ratelimited variants dev_warn/dev_err
Date: Fri, 21 Dec 2018 12:57:43 +0100 [thread overview]
Message-ID: <20181221115742.GA30351@redhat.com> (raw)
In-Reply-To: <b0b97478f9b2b9b12ad7bc04a1eb0af3bad6c5f3.camel@perches.com>
On Fri, Dec 21, 2018 at 03:19:31AM -0800, Joe Perches wrote:
> On Thu, 2018-12-20 at 16:16 +0100, Stanislaw Gruszka wrote:
> > As reported by Randy we can overwhelm logs on some USB error conditions.
> > To avoid that use dev_warn_ratelimited() and dev_err_ratelimitd().
> >
> > Reported-and-tested-by: Randy Oostdyk <linux-kernel@oostdyk.com>
> > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> > ---
> > drivers/net/wireless/ralink/rt2x00/rt2x00.h | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00.h b/drivers/net/wireless/ralink/rt2x00/rt2x00.h
> []
> > @@ -65,14 +65,19 @@
> > /* Utility printing macros
> > * rt2x00_probe_err is for messages when rt2x00_dev is uninitialized
> > */
> > +#define wiphy_err_ratelimited(wiphy, format, args...) \
> > + dev_err_ratelimited(&(wiphy)->dev, format, ##args)
> > +#define wiphy_warn_ratelimited(wiphy, format, args...) \
> > + dev_warn_ratelimited(&(wiphy)->dev, format, ##args)
> > +
>
> These should probably be generic in include/net/cfg80211.h
Since there are no other users I do not see reason for that.
Those macros can be easily move, if other users would show up.
Regards
Stanislaw
next prev parent reply other threads:[~2018-12-21 11:57 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 15:16 [PATCH v2 1/3] rt2x00: use ratelimited variants dev_warn/dev_err Stanislaw Gruszka
2018-12-20 15:16 ` [PATCH v2 2/3] rt2x00: check number of EPROTO errors Stanislaw Gruszka
2019-01-07 12:47 ` Jeroen Roovers
2019-01-07 15:09 ` Stanislaw Gruszka
2019-01-08 9:30 ` Jeroen Roovers
2019-01-08 10:09 ` Jeroen Roovers
2019-01-08 11:04 ` Tom Psyborg
2019-01-09 6:17 ` Jeroen Roovers
2019-01-09 11:33 ` Stanislaw Gruszka
2019-01-10 7:49 ` Jeroen Roovers
2019-01-10 14:29 ` Jeroen Roovers
2019-01-16 11:11 ` Stanislaw Gruszka
2019-01-22 17:32 ` Jeroen Roovers
2019-02-12 15:02 ` Stanislaw Gruszka
2018-12-20 15:16 ` [PATCH v2 3/3] rt2x00: do not print error when queue is full Stanislaw Gruszka
2018-12-20 17:52 ` Tom Psyborg
2018-12-21 9:59 ` Stanislaw Gruszka
2018-12-22 13:12 ` Tom Psyborg
2018-12-25 22:43 ` Tom Psyborg
2018-12-27 10:32 ` Stanislaw Gruszka
2018-12-27 10:25 ` Stanislaw Gruszka
2018-12-28 0:45 ` Tom Psyborg
2019-01-02 8:19 ` Stanislaw Gruszka
2019-02-09 11:03 ` Stanislaw Gruszka
2019-02-09 11:11 ` Tom Psyborg
2019-02-09 11:56 ` Stanislaw Gruszka
2019-02-09 12:28 ` Tom Psyborg
2019-02-09 15:38 ` Daniel Golle
2019-02-09 16:29 ` Tom Psyborg
2019-02-09 17:28 ` Daniel Golle
2019-03-19 2:37 ` Tom Psyborg
2019-02-10 9:57 ` Stanislaw Gruszka
2018-12-21 11:19 ` [PATCH v2 1/3] rt2x00: use ratelimited variants dev_warn/dev_err Joe Perches
2018-12-21 11:57 ` Stanislaw Gruszka [this message]
2018-12-21 12:48 ` Joe Perches
2018-12-21 12:51 ` Stanislaw Gruszka
2019-01-29 12:30 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181221115742.GA30351@redhat.com \
--to=sgruszka@redhat.com \
--cc=daniel@makrotopia.org \
--cc=dev@kresin.me \
--cc=joe@perches.com \
--cc=linux-kernel@oostdyk.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=pozega.tomislav@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).