From: Jean Delvare <jdelvare@suse.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org,
"Peter Lebbing" <peter@digitalbrains.com>,
"Felix Fietkau" <nbd@nbd.name>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Johannes Berg" <johannes.berg@intel.com>
Subject: Re: [PATCH] Revert "mac80211: set NETIF_F_LLTX when using intermediate tx queues"
Date: Tue, 30 Jul 2019 16:04:36 +0200 [thread overview]
Message-ID: <20190730160436.78b72b50@endymion> (raw)
In-Reply-To: <20190730125412.1446-1-johannes@sipsolutions.net>
On Tue, 30 Jul 2019 14:54:11 +0200, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> Revert this for now, it has been reported multiple times that it
> completely breaks connectivity on various devices.
>
> Cc: stable@vger.kernel.org
> Fixes: 8dbb000ee73b ("mac80211: set NETIF_F_LLTX when using intermediate tx queues")
> Reported-by: Jean Delvare <jdelvare@suse.de>
> Reported-by: Peter Lebbing <peter@digitalbrains.com>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> net/mac80211/iface.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
> index 06aac0aaae64..8dc6580e1787 100644
> --- a/net/mac80211/iface.c
> +++ b/net/mac80211/iface.c
> @@ -1222,7 +1222,6 @@ static void ieee80211_if_setup(struct net_device *dev)
> static void ieee80211_if_setup_no_queue(struct net_device *dev)
> {
> ieee80211_if_setup(dev);
> - dev->features |= NETIF_F_LLTX;
> dev->priv_flags |= IFF_NO_QUEUE;
> }
>
Thanks Johannes.
Tested-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2019-07-30 14:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 12:54 [PATCH] Revert "mac80211: set NETIF_F_LLTX when using intermediate tx queues" Johannes Berg
2019-07-30 14:04 ` Jean Delvare [this message]
2019-07-31 11:29 ` Peter Lebbing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730160436.78b72b50@endymion \
--to=jdelvare@suse.de \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=peter@digitalbrains.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).