From: Kalle Valo <kvalo@codeaurora.org>
To: Bhagavathi Perumal S <bperumal@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
Bhagavathi Perumal S <bperumal@codeaurora.org>
Subject: Re: [PATCH v3] ath11k: Add missing pdev rx rate stats
Date: Wed, 18 Dec 2019 11:52:48 +0000 (UTC) [thread overview]
Message-ID: <20191218115248.CE06FC43383@smtp.codeaurora.org> (raw)
In-Reply-To: <0101016ed1b43bf2-1e21d5b3-b396-446f-9f19-c7de3df29a61-000000@us-west-2.amazonses.com>
Bhagavathi Perumal S <bperumal@codeaurora.org> wrote:
> This adds missing rx rate info stats like pilot evm,
> per chain rssi, per user ul ppdu and mpdu counts and
> ul ofdma rate info etc.
>
> And add null checks for memory alloc failures.
>
> Signed-off-by: Bhagavathi Perumal S <bperumal@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
This one has warnings, please fix and resend:
drivers/net/wireless/ath/ath11k/debug_htt_stats.c:2846:59: warning: Using plain integer as NULL pointer
drivers/net/wireless/ath/ath11k/debug_htt_stats.c:3025:68: warning: Using plain integer as NULL pointer
drivers/net/wireless/ath/ath11k/debug_htt_stats.c:3026:59: warning: Using plain integer as NULL pointer
drivers/net/wireless/ath/ath11k/debug_htt_stats.c:3028:73: warning: Using plain integer as NULL pointer
drivers/net/wireless/ath/ath11k/debug_htt_stats.c:779:59: warning: Using plain integer as NULL pointer
drivers/net/wireless/ath/ath11k/debug_htt_stats.c:867:68: warning: Using plain integer as NULL pointer
drivers/net/wireless/ath/ath11k/debug_htt_stats.c:868:59: warning: Using plain integer as NULL pointer
drivers/net/wireless/ath/ath11k/debug_htt_stats.h:1294: Avoid CamelCase: <rx_pilot_evm_dB>
drivers/net/wireless/ath/ath11k/debug_htt_stats.h:1300: Avoid CamelCase: <rx_pilot_evm_dB_mean>
drivers/net/wireless/ath/ath11k/debug_htt_stats.c:3028: Avoid CamelCase: <rx_pilot_evm_dB>
drivers/net/wireless/ath/ath11k/debug_htt_stats.c:3114: Avoid CamelCase: <rx_pilot_evm_dB_mean>
--
https://patchwork.kernel.org/patch/11273269/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2019-12-18 11:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 16:18 [PATCH v3] ath11k: Add missing pdev rx rate stats Bhagavathi Perumal S
2019-12-18 11:52 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218115248.CE06FC43383@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=bperumal@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).