From: Kalle Valo <kvalo@codeaurora.org>
To: Zekun Shen <bruceshenzk@gmail.com>
Cc: unlisted-recipients:; (no To-header on input)
security@kernel.org, Zekun Shen <bruceshenzk@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ath10k: fix OOB: __ath10k_htt_rx_ring_fill_n
Date: Mon, 20 Jul 2020 17:10:35 +0000 (UTC) [thread overview]
Message-ID: <20200720171035.89558C433CB@smtp.codeaurora.org> (raw)
In-Reply-To: <20200623221105.3486-1-bruceshenzk@gmail.com>
Zekun Shen <bruceshenzk@gmail.com> wrote:
> The idx in __ath10k_htt_rx_ring_fill_n function lives in
> consistent dma region writable by the device. Malfunctional
> or malicious device could manipulate such idx to have a OOB
> write. Either by
> htt->rx_ring.netbufs_ring[idx] = skb;
> or by
> ath10k_htt_set_paddrs_ring(htt, paddr, idx);
>
> The idx can also be negative as it's signed, giving a large
> memory space to write to.
>
> It's possibly exploitable by corruptting a legit pointer with
> a skb pointer. And then fill skb with payload as rougue object.
>
> Part of the log here. Sometimes it appears as UAF when writing
> to a freed memory by chance.
>
> [ 15.594376] BUG: unable to handle page fault for address: ffff887f5c1804f0
> [ 15.595483] #PF: supervisor write access in kernel mode
> [ 15.596250] #PF: error_code(0x0002) - not-present page
> [ 15.597013] PGD 0 P4D 0
> [ 15.597395] Oops: 0002 [#1] SMP KASAN PTI
> [ 15.597967] CPU: 0 PID: 82 Comm: kworker/u2:2 Not tainted 5.6.0 #69
> [ 15.598843] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996),
> BIOS rel-1.12.1-0-ga5cab58e9a3f-prebuilt.qemu.org 04/01/2014
> [ 15.600438] Workqueue: ath10k_wq ath10k_core_register_work [ath10k_core]
> [ 15.601389] RIP: 0010:__ath10k_htt_rx_ring_fill_n
> (linux/drivers/net/wireless/ath/ath10k/htt_rx.c:173) ath10k_core
>
> Signed-off-by: Zekun Shen <bruceshenzk@gmail.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
bad60b8d1a71 ath10k: check idx validity in __ath10k_htt_rx_ring_fill_n()
--
https://patchwork.kernel.org/patch/11621899/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-07-20 17:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 22:11 [PATCH] net: ath10k: fix OOB: __ath10k_htt_rx_ring_fill_n Zekun Shen
2020-07-15 15:26 ` Kalle Valo
2020-07-20 17:10 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720171035.89558C433CB@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=bruceshenzk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).