From: Joe Perches <joe@perches.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Krzysztof Opasiak <k.opasiak@samsung.com>,
Mark Greer <mgreer@animalcreek.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-nfc@lists.01.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [RESEND PATCH v2 2/7] nfc: nci: replace GPLv2 boilerplate with SPDX
Date: Fri, 08 Oct 2021 03:54:53 -0700 [thread overview]
Message-ID: <21a4fcacc72b6d45576da7c78001a519d275a2ea.camel@perches.com> (raw)
In-Reply-To: <9669a6cd-77de-ca0c-153c-75b531bd2490@canonical.com>
On Fri, 2021-10-08 at 12:46 +0200, Krzysztof Kozlowski wrote:
> On 08/10/2021 12:33, Joe Perches wrote:
> > On Thu, 2021-10-07 at 15:30 +0200, Krzysztof Kozlowski wrote:
> > > Replace standard GPLv2 only license text with SPDX tag.
> >
> > Nak
> >
> > This is actually licenced with GPL-2.0-or-later
> >
> > > diff --git a/net/nfc/nci/uart.c b/net/nfc/nci/uart.c
> > []
> > > @@ -1,20 +1,8 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > []
> > You may use, redistribute and/or modify this File in
> > > - * accordance with the terms and conditions of the License, a copy of which
> > > - * is available on the worldwide web at
> > > - * http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt.
> >
> > See the actual text at the old link which includes:
> >
> > This program is free software; you can redistribute it and/or modify
> > it under the terms of the GNU General Public License as published by
> > the Free Software Foundation; either version 2 of the License, or
> > (at your option) any later version.
>
>
> Thanks Joe for checking this. Isn't this conflicting with first
> paragraph in the source file:
>
> This software file (the "File") is distributed by Marvell
> InternationalLtd. under the terms of the GNU General Public License
> Version 2, June 1991(the "License").
>
> This part does not specify "or later".
It doesn't need to as it calls out the exact license which by
specific reference includes the "or later".
And this is a nominal 'weakness' in the spdx license referencing
system which relies on contents of files in the LICENSE directory.
next prev parent reply other threads:[~2021-10-08 10:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 13:30 [RESEND PATCH v2 0/7] nfc: minor printk cleanup Krzysztof Kozlowski
2021-10-07 13:30 ` [RESEND PATCH v2 1/7] nfc: drop unneeded debug prints Krzysztof Kozlowski
2021-10-07 13:30 ` [RESEND PATCH v2 2/7] nfc: nci: replace GPLv2 boilerplate with SPDX Krzysztof Kozlowski
2021-10-08 10:33 ` Joe Perches
2021-10-08 10:46 ` Krzysztof Kozlowski
2021-10-08 10:54 ` Joe Perches [this message]
2021-10-07 13:30 ` [RESEND PATCH v2 3/7] nfc: s3fwrn5: simplify dereferencing pointer to struct device Krzysztof Kozlowski
2021-10-07 13:30 ` [RESEND PATCH v2 4/7] nfc: st-nci: drop unneeded debug prints Krzysztof Kozlowski
2021-10-07 13:30 ` [RESEND PATCH v2 5/7] nfc: st21nfca: " Krzysztof Kozlowski
2021-10-07 13:30 ` [RESEND PATCH v2 6/7] nfc: trf7970a: " Krzysztof Kozlowski
2021-10-07 13:30 ` [RESEND PATCH v2 7/7] nfc: microread: " Krzysztof Kozlowski
2021-10-08 10:16 ` [RESEND PATCH v2 0/7] nfc: minor printk cleanup David Miller
2021-10-08 10:18 ` Krzysztof Kozlowski
2021-10-10 11:36 ` Krzysztof Kozlowski
2021-10-11 13:03 ` Jakub Kicinski
2021-10-11 13:33 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21a4fcacc72b6d45576da7c78001a519d275a2ea.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=k.opasiak@samsung.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mgreer@animalcreek.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).