Re: [PATCH for v5.17 1/2] iwlwifi: remove deprecated broadcast filtering feature

[Thorsten Leemhuis <regressions@leemhuis.info>]

On 31.01.22 12:12, Kalle Valo wrote:
> Thorsten Leemhuis <regressions@leemhuis.info> writes:
>> On 28.01.22 13:48, Luca Coelho wrote:
>>> From: Luca Coelho <luciano.coelho@intel.com>
>>>
>>> This feature has been deprecated and should not be used anymore.  With
>>> newer firmwares, namely *-67.ucode and above, trying to use it causes an
>>> assertion failure in the FW, similar to this:
>>>
>>> [Tue Jan 11 20:05:24 2022] iwlwifi 0000:04:00.0: 0x00001062 | ADVANCED_SYSASSERT
>>>
>>> In order to prevent this feature from being used, remove it entirely
>>> and get rid of the Kconfig option that
>>> enables it (IWLWIFI_BCAST_FILTERING).
>>>
>>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=215488
>>
>> FWIW there was another report about it afaics:
>>
>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=215550
> 
> If it's the same issue, it should be marked as a duplicate.

Understandable request, but sorry, for now I decided to not do that in
such situations for two reasons:

 * it can easily go wrong, as I encounter all sorts of kernel bugs and
thus often lack detailed knowledge about the areas the bug is about

 * I'm doing regression tacking in my spare time, which is hard enough
already; taking care of bugs would make it a lot harder -- especially as
some maintainers/subsystems seem to (mostly) ignore bugzilla, so I would
be starting to do their job. Hence I only look at bugzilla to make sure
no regressions reported there falls through the cracks. See also:
https://lore.kernel.org/regressions/3ee8c6c9-52d1-9570-f3bf-490365c9f6fe@leemhuis.info/


>> That makes me hope that this is reviewed and merged to mainline relative
>> quickly, otherwise more users will be bothered by this.
>>
>>> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
>>> Fixes: cbaa6aeedee5 ("iwlwifi: bump FW API to 67 for AX devices")
>>> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
>>
>> Shouldn't this also have:
>>
>> Cc: stable@vger.kernel.org # 5.16.x
> 
> I can add that.

thx.

> BTW, please trim your quotes. You left a really long (and unnecessary)
> quote, which makes use of patchwork much harder for us maintainers.
> Unfortunately patchwork is not able to trim them automatically:

Argh, sorry, of course, will do that. I normally trim a lot more, but
when I'm in "regression tracker mode" I work differently and quote more,
as I often have to poke discussions that got stalled -- and there the
context might be helpful. But you are obviously right, for patches and
quite a few other situations that's obviously unneeded and harmful.

Ciao, Thorsten