linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: leiwa@codeaurora.org
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] ath10k: fix different tx duration output
Date: Thu, 18 Apr 2019 15:26:57 +0800	[thread overview]
Message-ID: <298a645b17aac0f5c466f011225533b0@codeaurora.org> (raw)
In-Reply-To: <87mukprnie.fsf@toke.dk>

On 2019-04-17 17:26, Toke Høiland-Jørgensen wrote:
> Lei Wang <leiwa@codeaurora.org> writes:
> 
>> TX duration output of tx_stats in debugfs and station dump had big
>> difference because they got tx duration value from different statistic
>> data. We should use the same statistic data.
> 
> So are you sure you picked the most accurate one of the two? :)
> 
> -Toke

Hi Toke,

Yes.
Now for ath10k, there are two ways to get tx duration output.
One is got from tx_stats in debugfs reported by firmware. It is a total 
value including all the frames which created by host and firmware sent 
to the peer.
And the second is calculated from 
ath10k_htt_rx_tx_compl_ind()-->ieee80211_sta_register_airtime(), here 
the tx duration just includes the data frames sent from host to the 
peer.
So the first value is preferable for station dump.

Thanks.
Lei

  reply	other threads:[~2019-04-18  7:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17  8:17 [PATCH v2] ath10k: fix different tx duration output Lei Wang
2019-04-17  9:26 ` Toke Høiland-Jørgensen
2019-04-18  7:26   ` leiwa [this message]
2019-04-18  8:07     ` Toke Høiland-Jørgensen
2019-05-07 11:14       ` leiwa
2019-05-07 11:43         ` Toke Høiland-Jørgensen
2019-05-07 14:05 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=298a645b17aac0f5c466f011225533b0@codeaurora.org \
    --to=leiwa@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=toke@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).