From: Felix Fietkau <nbd@nbd.name>
To: Balakrishna Bandi <b.balakrishna@globaledgesoft.com>,
lorenzo.bianconi83@gmail.com
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/1] [PATCH] Mt76 enabling data pkt transmission.
Date: Thu, 22 Aug 2019 09:45:23 +0200 [thread overview]
Message-ID: <2e116b8f-2340-e951-93b7-224b399a22de@nbd.name> (raw)
In-Reply-To: <1566335498-10977-1-git-send-email-b.balakrishna@globaledgesoft.com>
On 2019-08-20 23:11, Balakrishna Bandi wrote:
> Data Packet transmission was disabled during scanning in mt76 driver.
>
> Fix to be, enabling data packet transmission during scanning.
>
> Note:
> Mac80211 will handle channel switching. During scanning, it handles
> stopping the data transmission on off channel and enabling data
> transmission on operating channel also. It does not require to stop data
> transmission in mt76 driver during scanning. Verified with other driver
> ath9k and rt2x00 driver, data transmission was not stopped during
> scanning
>
> Signed-off-by: Balakrishna Bandi <b.balakrishna@globaledgesoft.com>
> ---
> drivers/net/wireless/mediatek/mt76/tx.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/tx.c b/drivers/net/wireless/mediatek/mt76/tx.c
> index 5397827..376720d 100644
> --- a/drivers/net/wireless/mediatek/mt76/tx.c
> +++ b/drivers/net/wireless/mediatek/mt76/tx.c
> @@ -438,8 +438,7 @@ void mt76_tx_complete_skb(struct mt76_dev *dev, struct sk_buff *skb)
> if (probe)
> break;
>
> - if (test_bit(MT76_OFFCHANNEL, &dev->state) ||
> - test_bit(MT76_RESET, &dev->state))
> + if (test_bit(MT76_RESET, &dev->state))
The patch is incomplete, since this test is done twice in the tx path.
Also, the subject line is wrong. I will send a more complete fix.
Thanks,
- Felix
prev parent reply other threads:[~2019-08-22 7:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 21:11 [PATCH 1/1] [PATCH] Mt76 enabling data pkt transmission Balakrishna Bandi
2019-08-22 7:45 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e116b8f-2340-e951-93b7-224b399a22de@nbd.name \
--to=nbd@nbd.name \
--cc=b.balakrishna@globaledgesoft.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).