From: Denis Kenzior <denkenz@gmail.com>
To: Dan Williams <dcbw@redhat.com>,
Johannes Berg <johannes@sipsolutions.net>,
James Prestwood <prestwoj@gmail.com>,
linux-wireless@vger.kernel.org
Subject: Re: [RFC 0/1] Allow MAC change on up interface
Date: Tue, 20 Aug 2019 13:21:04 -0500 [thread overview]
Message-ID: <32a1bddd-2472-10a3-4d0d-5634814e635b@gmail.com> (raw)
In-Reply-To: <32547793981b3997f7e0f74137745f38615e5c54.camel@redhat.com>
Hi Dan,
On 8/20/19 12:53 PM, Dan Williams wrote:
> On Tue, 2019-08-20 at 10:40 -0500, Denis Kenzior wrote:
>> Hi Johannes,
>>
>>> Stop.
>>>
>>> Your tone, and in particular the constant snide comments and
>>> attacks on
>>> me are, quite frankly, getting extremely tiring.
>>>
>>
>> Look, I'm sorry I hit a nerve, but from where I am sitting, it had to
>> be
>> said...
>
> But did it really? And in that way? There were certainly better ways
> to go about that response.
The issue is that this isn't the first such occurrence. There is a
pattern here and it needs to change. So +1 on handling this better.
>
> I don't recall seeing a NAK anywhere his email chain (which you'd get
> with some other kernel maintainers) but instead (a) an explanation of
> why the proposed solution had some problems, (b) some alternative
> possibilities and (c) requests for more information so the discussion
> could continue.
So the cover letter states:
"Set IFF_LIVE_ADDR_CHANGE on net_device. Note: I know setting this
where I did is likely not the right way to do it, but for this
proof-of-concept it works. With guidance I can move this around
to a proper place."
and I'll leave it up to you to read the first response from the maintainer.
>
> It does the requested changes no good to take that kind of tone. Let's
Neither is:
"don't do that then"
or
"I'm not really sure I see any point in this to start with"
or
"To me, the whole thing seems like more of a problem than a solution."
> move on from here and keep things constructive to solve the problem at
> hand, which is:
>
> "Changing the MAC address of a WiFi interface takes longer than I'd
> like and clears some state that I'd like it to keep."
>
> That is a technical problem we can solve, so let's keep it at that
> level.
>
I'm all for moving on and having the people that know this stuff well
giving actual guidance, as was requested originally.
Regards,
-Denis
next prev parent reply other threads:[~2019-08-20 18:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 18:57 [RFC 0/1] Allow MAC change on up interface James Prestwood
2019-08-15 18:57 ` [RFC 1/1] RFC: allow mac address change on up iface James Prestwood
2019-08-15 20:48 ` [RFC 0/1] Allow MAC change on up interface Jeff Johnson
2019-08-16 9:56 ` Toke Høiland-Jørgensen
2019-08-19 10:14 ` Johannes Berg
2019-08-19 15:55 ` James Prestwood
2019-08-19 20:20 ` Johannes Berg
2019-08-19 20:58 ` Denis Kenzior
2019-08-20 8:59 ` Johannes Berg
2019-08-20 15:40 ` Denis Kenzior
2019-08-20 17:53 ` Dan Williams
2019-08-20 18:21 ` Denis Kenzior [this message]
2019-08-20 18:54 ` Toke Høiland-Jørgensen
2019-08-20 19:32 ` Johannes Berg
2019-08-20 19:46 ` Denis Kenzior
2019-08-20 20:01 ` Johannes Berg
2019-08-19 21:14 ` James Prestwood
2019-08-20 6:59 ` Johannes Berg
2019-08-20 19:22 ` Denis Kenzior
2019-08-20 19:43 ` Johannes Berg
2019-08-20 19:58 ` Denis Kenzior
2019-08-20 20:15 ` Johannes Berg
2019-08-20 20:37 ` Denis Kenzior
2019-08-20 21:18 ` Dan Williams
2019-08-20 21:52 ` Denis Kenzior
2019-08-21 7:21 ` Johannes Berg
2019-08-20 19:53 ` James Prestwood
2019-08-20 20:06 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32a1bddd-2472-10a3-4d0d-5634814e635b@gmail.com \
--to=denkenz@gmail.com \
--cc=dcbw@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=prestwoj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).