linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Rui Salvaterra <rsalvaterra@gmail.com>,
	b43-dev@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [BUG?] b43: can't connect to WPA3 network (nohwcrypt=1)
Date: Tue, 19 May 2020 15:30:51 -0500	[thread overview]
Message-ID: <3483242e-c2ad-ec83-0c2c-ce952bc9b638@lwfinger.net> (raw)
In-Reply-To: <CALjTZvbLOr5zAYyp75Cs6Zo8mWNUVq3ZRJu56G1iHdiihFejWQ@mail.gmail.com>

On 5/19/20 9:18 AM, Rui Salvaterra wrote:
> Hi, everyone!
> 
> I've been trying to connect to a WPA3 (personal, not enterprise)
> network but, as expected, the connection always fails with hardware
> encryption (most likely due to mandatory MFP, which the hardware won't
> do). What I didn't expect was to have the exact same problem when
> using software crypto. I've tried with other devices, and they work
> fine. One thing I noticed is this: for example, a Ralink RT2790
> device, on another machine, shows the following supported cyphers with
> hardware crypto…
> 
>          * WEP40 (00-0f-ac:1)
>          * WEP104 (00-0f-ac:5)
>          * TKIP (00-0f-ac:2)
>          * CCMP-128 (00-0f-ac:4)
>          * CCMP-256 (00-0f-ac:10)
>          * GCMP-128 (00-0f-ac:8)
>          * GCMP-256 (00-0f-ac:9)
> 
> … and with software crypto…
> 
>          * WEP40 (00-0f-ac:1)
>          * WEP104 (00-0f-ac:5)
>          * TKIP (00-0f-ac:2)
>          * CCMP-128 (00-0f-ac:4)
>          * CCMP-256 (00-0f-ac:10)
>          * GCMP-128 (00-0f-ac:8)
>          * GCMP-256 (00-0f-ac:9)
>          * CMAC (00-0f-ac:6)
>          * CMAC-256 (00-0f-ac:13)
>          * GMAC-128 (00-0f-ac:11)
>          * GMAC-256 (00-0f-ac:12)
> 
> … while b43 shows exactly the same in both modes…
> 
>          * WEP40 (00-0f-ac:1)
>          * WEP104 (00-0f-ac:5)
>          * TKIP (00-0f-ac:2)
>          * CCMP-128 (00-0f-ac:4)
>          * CCMP-256 (00-0f-ac:10)
>          * GCMP-128 (00-0f-ac:8)
>          * GCMP-256 (00-0f-ac:9)
> 
> This is a BCM4318 device (PCI ID 14e4:4318), but I don't know if
> that's relevant.
> Is this behaviour expected?
> 
> Thanks in advance,
> Rui
> 

Rui,

 From other drivers, it appears that handling WPA3 might be as simple as setting 
MFP_CAPABLE in the hardware capabilities. Please try this patch:

diff --git a/drivers/net/wireless/broadcom/b43/main.c 
b/drivers/net/wireless/broadcom/b43/main.c
index 39da1a4c30ac..e944fe2e9ac7 100644
--- a/drivers/net/wireless/broadcom/b43/main.c
+++ b/drivers/net/wireless/broadcom/b43/main.c
@@ -4162,8 +4162,11 @@ static int b43_op_set_key(struct ieee80211_hw *hw, enum 
set_key_cmd cmd,
         int err;
         static const u8 bcast_addr[ETH_ALEN] = { 0xff, 0xff, 0xff, 0xff, 0xff, 
0xff };

-       if (modparam_nohwcrypt)
+       if (modparam_nohwcrypt) {
+               /* User disabled HW-crypto - enable MFP (WPA3) */
+               ieee80211_hw_set(hw, MFP_CAPABLE);
                 return -ENOSPC; /* User disabled HW-crypto */
+       }

         if ((vif->type == NL80211_IFTYPE_ADHOC ||
              vif->type == NL80211_IFTYPE_MESH_POINT) &&

I have no way of testing other than to compile.

Larry


  reply	other threads:[~2020-05-19 20:30 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19 14:18 [BUG?] b43: can't connect to WPA3 network (nohwcrypt=1) Rui Salvaterra
2020-05-19 20:30 ` Larry Finger [this message]
2020-05-19 20:36   ` Rui Salvaterra
2020-05-19 23:13     ` Rui Salvaterra
2020-05-20  0:16       ` Larry Finger
2020-05-20  8:24         ` Rui Salvaterra
2020-05-20 10:55           ` Rui Salvaterra
2020-05-20 20:08             ` Larry Finger
2020-05-20 20:28               ` Rui Salvaterra
2020-05-20 20:56                 ` Larry Finger
2020-05-21  8:35                   ` Rui Salvaterra
2020-05-21  9:07                     ` Rui Salvaterra
2020-05-21 10:46                       ` Michael Büsch
2020-05-21 11:30                         ` Rui Salvaterra
2020-05-21 11:40                           ` Michael Büsch
2020-05-21 14:10                             ` Larry Finger
2020-05-21 14:52                             ` Rui Salvaterra
2020-05-21 16:17                               ` Rui Salvaterra
2020-05-21 18:59                                 ` Larry Finger
2020-05-21 19:19                                   ` Rui Salvaterra
2020-05-21 20:23                                     ` Rui Salvaterra
2020-05-21 21:47                                       ` Larry Finger
2020-05-22 10:19                                         ` Michael Büsch
2020-05-22 11:49                                           ` Kalle Valo
2020-05-22 13:46                                             ` Rui Salvaterra
2020-05-22 18:02                                               ` Larry Finger
2020-05-22 20:04                                                 ` Rui Salvaterra
2020-05-22 20:40                                                 ` Rui Salvaterra
2020-05-22 21:06                                                   ` Larry Finger
2020-05-23  0:35                                                     ` Rui Salvaterra
2020-05-23 21:17                                                     ` Rafał Miłecki
2020-05-25  6:56                                                       ` Kalle Valo
2020-05-22 17:15                                             ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3483242e-c2ad-ec83-0c2c-ce952bc9b638@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=b43-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rsalvaterra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).