linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Alexei Lazar <ailizaro@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com
Subject: Re: [PATCH v3 1/2] nl80211: Add support for EDMG channels
Date: Fri, 28 Jun 2019 15:07:33 +0200	[thread overview]
Message-ID: <43145d452ad33bfa39e5bdb5e522cc82140de23b.camel@sipsolutions.net> (raw)
In-Reply-To: <40d70ed94b1d79d481511031e8f4ea45@codeaurora.org>

On Tue, 2019-06-25 at 13:21 +0300, Alexei Lazar wrote:
> 
> > >   * @NL80211_BAND_ATTR_VHT_CAPA: VHT capabilities, as in the HT 
> > > information IE
> > >   * @NL80211_BAND_ATTR_IFTYPE_DATA: nested array attribute, with each 
> > > entry using
> > >   *	attributes from &enum nl80211_band_iftype_attr
> > > + * @NL80211_BAND_ATTR_EDMG_CHANNELS: bitmap that indicates the 2.16 
> > > GHz
> > > + *	channel(s) that are allowed to be used for EDMG transmissions in 
> > > the
> > > + *	BSS as defined by IEEE 802.11 section 9.4.2.251.
> > > + * @NL80211_BAND_ATTR_EDMG_BW_CONFIG: Channel BW Configuration 
> > > subfield
> > > + *	encodes the allowed channel bandwidth configurations as defined by
> > > + *	IEEE 802.11 section 9.4.2.251, Table 13.
> > >   * @NL80211_BAND_ATTR_MAX: highest band attribute currently defined
> > >   * @__NL80211_BAND_ATTR_AFTER_LAST: internal use
> > 
> > And ... that makes more sense than the global attribute I guess?
> 
> We feel it belongs to the BAND attributes because for example also VHT
> capability is there. There are however 2 other options:
> 1. Move the attribute to the NL80211_FREQUENCY_ATTR
> 2. Move them to the global attributes
> Any preference?

I think I just got confused. Is this used for capability reporting then?
I guess that'd make sense here, yeah.

johannes


  reply	other threads:[~2019-06-28 13:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20 14:53 [PATCH v3 0/2] Add support for new channels on 60GHz band Alexei Avshalom Lazar
2019-05-20 14:53 ` [PATCH v3 1/2] nl80211: Add support for EDMG channels Alexei Avshalom Lazar
2019-06-14 12:31   ` Johannes Berg
2019-06-25 10:21     ` Alexei Lazar
2019-06-28 13:07       ` Johannes Berg [this message]
2019-05-20 14:53 ` [PATCH v3 2/2] wil6210: Add EDMG channel support Alexei Avshalom Lazar
2019-05-21 15:15 ` [PATCH v3 0/2] Add support for new channels on 60GHz band Kalle Valo
2019-06-25 10:29 Alexei Avshalom Lazar
2019-06-25 10:29 ` [PATCH v3 1/2] nl80211: Add support for EDMG channels Alexei Avshalom Lazar
2019-06-28 13:21   ` Johannes Berg
2019-07-07 14:11     ` Alexei Lazar
2019-07-12  8:03       ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43145d452ad33bfa39e5bdb5e522cc82140de23b.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=ailizaro@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=wil6210@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).