From: Lubomir Rintel <lkundrak@v3.sk>
To: YueHaibing <yuehaibing@huawei.com>, Kalle Valo <kvalo@codeaurora.org>
Cc: libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] libertas: remove set but not used variable 'int_type'
Date: Tue, 23 Oct 2018 16:25:11 +0200 [thread overview]
Message-ID: <56d49bb6e62e3a7246bd839a349874908e6a9673.camel@v3.sk> (raw)
In-Reply-To: <1539569795-176889-1-git-send-email-yuehaibing@huawei.com>
On Mon, 2018-10-15 at 02:16 +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/marvell/libertas/if_spi.c: In function
> 'if_spi_h2c':
> drivers/net/wireless/marvell/libertas/if_spi.c:799:6: warning:
> variable 'int_type' set but not used [-Wunused-but-set-variable]
>
> It never used since introduction in
> commit d2b21f191753 ("libertas: if_spi, driver for libertas GSPI
> devices")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks.
Tested-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
> drivers/net/wireless/marvell/libertas/if_spi.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/marvell/libertas/if_spi.c
> b/drivers/net/wireless/marvell/libertas/if_spi.c
> index 504d6e0..7c3224b 100644
> --- a/drivers/net/wireless/marvell/libertas/if_spi.c
> +++ b/drivers/net/wireless/marvell/libertas/if_spi.c
> @@ -796,15 +796,13 @@ static void if_spi_h2c(struct if_spi_card
> *card,
> {
> struct lbs_private *priv = card->priv;
> int err = 0;
> - u16 int_type, port_reg;
> + u16 port_reg;
>
> switch (type) {
> case MVMS_DAT:
> - int_type = IF_SPI_CIC_TX_DOWNLOAD_OVER;
> port_reg = IF_SPI_DATA_RDWRPORT_REG;
> break;
> case MVMS_CMD:
> - int_type = IF_SPI_CIC_CMD_DOWNLOAD_OVER;
> port_reg = IF_SPI_CMD_RDWRPORT_REG;
> break;
> default:
>
next prev parent reply other threads:[~2018-10-23 14:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 2:16 [PATCH] libertas: remove set but not used variable 'int_type' YueHaibing
2018-10-23 14:25 ` Lubomir Rintel [this message]
2018-11-06 16:52 ` Kalle Valo
2018-10-23 3:32 zhong jiang
2018-10-23 14:23 ` Lubomir Rintel
2018-10-23 14:28 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56d49bb6e62e3a7246bd839a349874908e6a9673.camel@v3.sk \
--to=lkundrak@v3.sk \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).