From: Markus Elfring <Markus.Elfring@web.de>
To: linux-wireless@vger.kernel.org, linuxwifi@intel.com,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Johannes Berg <johannes.berg@intel.com>,
Kalle Valo <kvalo@codeaurora.org>,
Luca Coelho <luciano.coelho@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org, Aditya Pakki <pakki001@umn.edu>,
Kangjie Lu <kjlu@umn.edu>, Navid Emamdoost <emamd001@umn.edu>,
Stephen McCamant <smccaman@umn.edu>
Subject: iwlwifi: Checking a kmemdup() call in iwl_req_fw_callback()
Date: Sat, 12 Oct 2019 19:26:24 +0200 [thread overview]
Message-ID: <71774617-79f9-1365-4267-a15a47422d10@web.de> (raw)
Hello,
I tried another script for the semantic patch language out.
This source code analysis approach points out that the implementation
of the function “iwl_req_fw_callback” contains still an unchecked call
of the function “kmemdup”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/wireless/intel/iwlwifi/iwl-drv.c?id=1c0cc5f1ae5ee5a6913704c0d75a6e99604ee30a#n1454
https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/net/wireless/intel/iwlwifi/iwl-drv.c#L1454
Can it be that just an other data structure member should be used
for the desired null pointer check at this place?
Regards,
Markus
next reply other threads:[~2019-10-12 17:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 17:26 Markus Elfring [this message]
2019-11-25 7:24 ` iwlwifi: Checking a kmemdup() call in iwl_req_fw_callback() Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71774617-79f9-1365-4267-a15a47422d10@web.de \
--to=markus.elfring@web.de \
--cc=davem@davemloft.net \
--cc=emamd001@umn.edu \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pakki001@umn.edu \
--cc=smccaman@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).