From: Jens Axboe <axboe@kernel.dk>
To: Luca Coelho <luca@coelho.fi>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Srinath Mannam <srinath.mannam@broadcom.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Johannes Berg <johannes@sipsolutions.net>,
"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>,
linuxwifi <linuxwifi@intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: iwlwifi firmware load broken in current -git
Date: Fri, 15 Sep 2017 13:55:57 -0600 [thread overview]
Message-ID: <79b26165-7baf-c6ee-7552-1ccccb3b7192@kernel.dk> (raw)
In-Reply-To: <1505505062.32032.1.camel@coelho.fi>
On 09/15/2017 01:51 PM, Luca Coelho wrote:
> On Fri, 2017-09-15 at 13:48 -0600, Jens Axboe wrote:
>> On 09/15/2017 01:38 PM, Linus Torvalds wrote:
>>> On Fri, Sep 15, 2017 at 12:32 PM, Jens Axboe <axboe@kernel.dk> wrote:
>>>>>
>>>>> In any case, your patch introduces a regression on systems. Please get
>>>>> it reverted now, and then you can come up with a new approach to fix the
>>>>> double enable of the upstream bridge.
>>>>
>>>> Who's sending in the revert? I can certainly do it if no one else does,
>>>> but it needs to be done.
>>>>
>>>> I'm not seeing any patches coming out of Srinath to fix up the
>>>> situation, so we should revert the broken patch until a better solution
>>>> exists.
>>>
>>> Hmm. I don't have the history here (apparently it never made lkml, for
>>> example), so I don't even know which commit you're talking about.
>>>
>>> From some of the context it looks like commit 40f11adc7cd9 ("PCI:
>>> Avoid race while enabling upstream bridges"), is that correct?
>>
>> Yes, Luca says that Bjorn already sent in the revert request, I just
>> didn't see it since I wasn't CC'ed on it. So looks like we're all
>> good, provided that makes it into -rc1. 40f11adc7cd9 is the broken
>> commit.
>
> Strange... AFAICT you *were* CCed on it. And so was everyone else in
> the original thread (+LKML)...
Hmm, never showed up here. Very odd!
--
Jens Axboe
next prev parent reply other threads:[~2017-09-15 19:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 15:48 iwlwifi firmware load broken in current -git Jens Axboe
2017-09-12 16:11 ` Coelho, Luciano
2017-09-12 16:35 ` Jens Axboe
2017-09-12 16:36 ` Luca Coelho
2017-09-12 16:59 ` Jens Axboe
2017-09-12 19:43 ` Jens Axboe
2017-09-12 19:51 ` Luca Coelho
2017-09-12 20:04 ` Johannes Berg
2017-09-14 17:00 ` Jens Axboe
2017-09-14 17:11 ` Bjorn Helgaas
2017-09-14 17:22 ` Jens Axboe
2017-09-14 17:28 ` Srinath Mannam
2017-09-14 17:35 ` Jens Axboe
2017-09-14 17:44 ` Srinath Mannam
2017-09-14 17:45 ` Jens Axboe
2017-09-14 17:50 ` Johannes Berg
2017-09-14 17:44 ` Jens Axboe
2017-09-14 20:04 ` Srinath Mannam
2017-09-14 20:36 ` Jens Axboe
2017-09-15 19:32 ` Jens Axboe
2017-09-15 19:36 ` Luca Coelho
2017-09-15 19:46 ` Jens Axboe
2017-09-15 19:38 ` Linus Torvalds
2017-09-15 19:43 ` Luca Coelho
2017-09-15 19:51 ` Linus Torvalds
2017-09-15 19:57 ` Jens Axboe
2017-09-15 19:48 ` Jens Axboe
2017-09-15 19:51 ` Luca Coelho
2017-09-15 19:55 ` Jens Axboe [this message]
2017-09-16 3:03 ` Bjorn Helgaas
2017-09-16 18:53 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79b26165-7baf-c6ee-7552-1ccccb3b7192@kernel.dk \
--to=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luca@coelho.fi \
--cc=srinath.mannam@broadcom.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).