linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aloka Dixit <alokad@codeaurora.org>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
	linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH v3 0/2] Unsolicited broadcast probe resp support
Date: Mon, 20 Jul 2020 14:36:49 -0700	[thread overview]
Message-ID: <7ced7462e3093c77831481663c92b971@codeaurora.org> (raw)
In-Reply-To: <8b8a5ec5-52e3-50e8-08e6-dc2ee20ec1bf@broadcom.com>

On 2020-07-16 02:35, Arend Van Spriel wrote:
> On 7/16/2020 1:05 AM, Aloka Dixit wrote:
>> Unsolicited broadcast probe response tranmission is used for in-band
>> discovery in 6GHz band (IEEE P802.11ax/D6.0 26.17.2.3.2, AP behavior 
>> for
>> fast passive scanning).
>> 
>> v3: Rebased. Removed check for 6Ghz, drivers should add that check.
> 
> I have not seen any comments in v2 so could you motivate this removal.
> It is a sanity check that is always needed so doing it in the nl80211
> api seems the proper place.
> 
> Regards,
> Arend

Hi Arend,
I found that if any application sends 
NL80211_ATTR_UNSOL_BCAST_PROBE_RESP with 
NL80211_UNSOL_BCAST_PROBE_RESP_INT=0 (which means disable) for 2.4/5GHz, 
the check here resulted in AP not being brought up.
Technically disabling this feature for 2.4/5GHz is not required as it is 
disabled by default but it should not cause issues if done so 
explicitly. Hence I removed the check here so that drivers can decide to 
use/ignore this attribute.

      reply	other threads:[~2020-07-20 21:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-15 23:05 [PATCH v3 0/2] Unsolicited broadcast probe resp support Aloka Dixit
2020-07-15 23:05 ` [PATCH v3 1/2] nl80211: Unsolicited broadcast probe response support Aloka Dixit
2020-08-03 10:18   ` Johannes Berg
2020-08-03 17:28     ` Aloka Dixit
2020-08-03 10:20   ` Johannes Berg
2020-08-03 17:30     ` Aloka Dixit
2020-08-03 10:20   ` Johannes Berg
2020-08-03 10:21     ` Johannes Berg
2020-08-03 17:33     ` Aloka Dixit
2020-07-15 23:05 ` [PATCH v3 2/2] mac80211: " Aloka Dixit
2020-07-16  9:35 ` [PATCH v3 0/2] Unsolicited broadcast probe resp support Arend Van Spriel
2020-07-20 21:36   ` Aloka Dixit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ced7462e3093c77831481663c92b971@codeaurora.org \
    --to=alokad@codeaurora.org \
    --cc=arend.vanspriel@broadcom.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless-owner@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).