From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Wen Gong <wgong@qti.qualcomm.com>,
Wen Gong <wgong@codeaurora.org>,
"ath10k\@lists.infradead.org" <ath10k@lists.infradead.org>
Cc: "linux-wireless\@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH 4/7] ath10k: disable TX complete indication of htt for sdio
Date: Wed, 21 Aug 2019 12:10:27 +0200 [thread overview]
Message-ID: <8736husub0.fsf@toke.dk> (raw)
In-Reply-To: <00992d0991704b0fae73a500bb2eb504@aptaiexm02f.ap.qualcomm.com>
Wen Gong <wgong@qti.qualcomm.com> writes:
>> -----Original Message-----
>> From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Toke
>> Høiland-Jørgensen
>> Sent: Tuesday, August 20, 2019 8:24 PM
>> To: Wen Gong <wgong@codeaurora.org>; ath10k@lists.infradead.org
>> Cc: linux-wireless@vger.kernel.org
>> Subject: [EXT] Re: [PATCH 4/7] ath10k: disable TX complete indication of htt
>> for sdio
>>
>> Wen Gong <wgong@codeaurora.org> writes:
>>
>> > Tx complete message from firmware cost bus bandwidth of sdio, and bus
>> > bandwidth is the bollteneck of throughput, it will effect the bandwidth
>> > occupancy of data packet of TX and RX.
>> >
>> > This patch disable TX complete indication from firmware for htt data
>> > packet, it results in significant performance improvement on TX path.
>>
>> Wait, how does that work? Am I understanding it correctly that this
>> replaces a per-packet TX completion with a periodic one sent out of
>> band?
> When this patch applied, firmware will not indicate tx complete for tx
> Data, it only indicate HTT_T2H_MSG_TYPE_TX_CREDIT_UPDATE_IND,
> This htt msg will tell how many data tx complete without status(status maybe success/fail).
Ah, so this is basically a counter of how much data is currently queued
in the firmware?
>> And could you explain what the credits thing is for, please? :)
> For high latency bus chip, all the tx data's content(include ip/udp/tcp header
> and payload) will be transfer to firmware's memory via bus.
> And firmware has limited memory for tx data, the tx data's content must
> Saved in firmware memory before it tx complete, if ath10k transfer tx
> data more than the limit, firmware will occur error. The credit is used
> to avoid ath10k exceed the limit.
What's a typical limit in the firmware?
-Toke
next prev parent reply other threads:[~2019-08-21 10:10 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 11:55 [PATCH 0/7] ath10k: improve throughout of tcp/udp TX/RX of sdio Wen Gong
2019-08-20 11:55 ` [PATCH 1/7] ath10k: enable RX bundle receive for sdio Wen Gong
2019-08-27 7:40 ` Nicolas Boichat
2019-08-27 8:02 ` Wen Gong
2019-08-27 8:08 ` Nicolas Boichat
2019-08-28 4:25 ` Wen Gong
2019-08-20 11:55 ` [PATCH 2/7] ath10k: change max RX bundle size from 8 to 32 " Wen Gong
2019-08-20 12:23 ` Toke Høiland-Jørgensen
2019-08-21 6:01 ` Wen Gong
2019-08-21 10:02 ` Toke Høiland-Jørgensen
2019-08-27 7:42 ` Nicolas Boichat
2019-08-28 2:31 ` Wen Gong
2019-09-03 16:09 ` Dave Taht
2019-09-04 4:43 ` Wen Gong
2019-09-04 13:34 ` Dave Taht
2019-09-05 10:12 ` Wen Gong
2019-08-20 11:55 ` [PATCH 3/7] ath10k: add workqueue for RX path of sdio Wen Gong
2019-09-04 2:31 ` Wen Gong
2019-08-20 11:55 ` [PATCH 4/7] ath10k: disable TX complete indication of htt for sdio Wen Gong
2019-08-20 12:23 ` Toke Høiland-Jørgensen
2019-08-21 6:20 ` Wen Gong
2019-08-21 10:10 ` Toke Høiland-Jørgensen [this message]
2019-08-21 10:20 ` Wen Gong
2019-08-22 12:12 ` Toke Høiland-Jørgensen
2019-08-23 2:46 ` Wen Gong
2019-08-23 8:39 ` Toke Høiland-Jørgensen
2019-08-27 7:56 ` Nicolas Boichat
2019-08-28 4:24 ` Wen Gong
2019-09-04 2:33 ` Wen Gong
2019-08-20 11:55 ` [PATCH 5/7] ath10k: add htt TX bundle " Wen Gong
2019-09-04 2:34 ` Wen Gong
2019-08-20 11:55 ` [PATCH 6/7] ath10k: enable alt data of TX path " Wen Gong
2019-09-04 2:36 ` Wen Gong
2019-08-20 11:55 ` [PATCH 7/7] ath10k: enable napi on RX " Wen Gong
2019-09-04 2:37 ` Wen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736husub0.fsf@toke.dk \
--to=toke@redhat.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wgong@codeaurora.org \
--cc=wgong@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).