From: Kalle Valo <kvalo@codeaurora.org>
To: Bernd Edlinger <bernd.edlinger@hotmail.de>
Cc: Ping-Ke Shih <pkshih@realtek.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v3 1/4] rtl8723ae: Take the FW LPS mode handling out
Date: Tue, 08 Jan 2019 19:27:59 +0200 [thread overview]
Message-ID: <875zuzqctc.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <DB7PR07MB535316A20C8447096DBC822DE4880@DB7PR07MB5353.eurprd07.prod.outlook.com> (Bernd Edlinger's message of "Sun, 6 Jan 2019 00:02:18 +0000")
Bernd Edlinger <bernd.edlinger@hotmail.de> writes:
> This appears to trigger a firmware bug and causes severe
> problems with rtl8723ae PCI devices.
>
> When the power save mode is activated for longer periods
> of time the firmware stops to receive any packets.
>
> This problem was exposed by commit 873ffe154ae0 ("rtlwifi:
> Fix logic error in enter/exit power-save mode").
>
> Previously the power save mode was only active rarely and
> only for a short time so that the problem was not noticeable.
>
> Signed-off-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
> ---
> v2: Adjust the defaults of swlps and fwlps module
> parameters to match the firmware capabilities instead of removing
> the whole code, so it can be easily re-activated once a firmware
> update is available.
>
> v3: Make the title fit in one line.
hotmail.de made me suspicious and indeed my Spidey sense was right:
Applying: rtl8723ae: Take the FW LPS mode handling out
Using index info to reconstruct a base tree...
.git/rebase-apply/patch:22: trailing whitespace.
.swctrl_lps = true,
.git/rebase-apply/patch:23: trailing whitespace.
.fwctrl_lps = false,
.git/rebase-apply/patch:33: trailing whitespace.
MODULE_PARM_DESC(swlps, "Set to 1 to use SW control power save (default 1)\n");
.git/rebase-apply/patch:34: trailing whitespace.
MODULE_PARM_DESC(fwlps, "Set to 1 to use FW control power save (default 0)\n");
error: patch failed: drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c:266
error: drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
Patch failed at 0001 rtl8723ae: Take the FW LPS mode handling out
Did you use Outlook to send this patch or what? Anyway, it's strongly
suggested to use git to submit the patches (and not use Outlook servers
either as they are notorious in breaking our patches):
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#format_issues
--
Kalle Valo
next prev parent reply other threads:[~2019-01-08 17:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-06 0:02 [PATCH v3 1/4] rtl8723ae: Take the FW LPS mode handling out Bernd Edlinger
2019-01-08 17:27 ` Kalle Valo [this message]
2019-01-08 22:20 ` Bernd Edlinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zuzqctc.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=andrew@lunn.ch \
--cc=bernd.edlinger@hotmail.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).