From: Kalle Valo <kvalo@codeaurora.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Maya Erez <merez@codeaurora.org>,
<linux-wireless@vger.kernel.org>, <wil6210@qti.qualcomm.com>,
<kernel-janitors@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] wil6210: fix debugfs_simple_attr.cocci warnings
Date: Fri, 05 Oct 2018 14:04:42 +0300 [thread overview]
Message-ID: <877eiw1wol.fsf@codeaurora.org> (raw)
In-Reply-To: <1538737646-118337-1-git-send-email-yuehaibing@huawei.com> (yuehaibing@huawei.com's message of "Fri, 5 Oct 2018 11:07:26 +0000")
YueHaibing <yuehaibing@huawei.com> writes:
> Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
> for debugfs files.
>
> Semantic patch information:
> Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
> imposes some significant overhead as compared to
> DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().
>
> Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
Just out of curiosity, what kind of overhead are we talking about here?
--
Kalle Valo
next prev parent reply other threads:[~2018-10-05 11:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 11:07 [PATCH] wil6210: fix debugfs_simple_attr.cocci warnings YueHaibing
2018-10-05 11:04 ` Kalle Valo [this message]
2018-10-05 11:51 ` YueHaibing
2018-10-05 14:29 ` Julia Lawall
2018-10-06 12:11 ` Kalle Valo
2018-10-06 12:22 ` Julia Lawall
2018-10-06 12:54 ` Kalle Valo
2018-10-13 17:29 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877eiw1wol.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=merez@codeaurora.org \
--cc=netdev@vger.kernel.org \
--cc=wil6210@qti.qualcomm.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).