From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org, pkshih@realtek.com
Subject: Re: [PATCH 5/5] rtlwifi: rtl8192cu: Fix value set in descriptor
Date: Tue, 20 Aug 2019 18:52:57 +0300 [thread overview]
Message-ID: <87d0gzal5y.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <8b4f8edf-fd73-2b88-b985-22658840f409@lwfinger.net> (Larry Finger's message of "Tue, 20 Aug 2019 10:36:19 -0500")
Larry Finger <Larry.Finger@lwfinger.net> writes:
> On 8/20/19 9:08 AM, Kalle Valo wrote:
>> Larry Finger <Larry.Finger@lwfinger.net> wrote:
>>
>>> In the process of converting the bit manipulation macros were converted
>>> to use GENMASK(), the compiler reported a value too big for the field.
>>> The offending statement was trying to write 0x100 into a 5-bit field.
>>> An accompaning comment says to set bit 3, thus the code is changed
>>> appropriately.
>>>
>>> This error has been in the driver since its initial submission.
>>>
>>> Fixes: 29d00a3e46bb ("rtlwifi: rtl8192cu: Add routine trx")
>>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>>
>> I only see patch 5 on patchwork, what happened to patches 1-4?
>
> I pulled them at the last minute, but forgot to rename the subject.
> Please apply that fix alone. The others will follow when I get time;
> however, they are code improvements. Only this one was a code fix.
Ok, I was just worried if patchwork had lost of them somehow.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-08-20 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 19:27 [PATCH 5/5] rtlwifi: rtl8192cu: Fix value set in descriptor Larry Finger
2019-08-20 14:08 ` Kalle Valo
2019-08-20 15:36 ` Larry Finger
2019-08-20 15:52 ` Kalle Valo [this message]
2019-09-03 13:28 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0gzal5y.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).