From: Kalle Valo <kvalo@codeaurora.org>
To: Jerome Pouiller <Jerome.Pouiller@silabs.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"David S . Miller" <davem@davemloft.net>,
devicetree@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
linux-mmc@vger.kernel.org, "Pali Rohár" <pali@kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>
Subject: Re: [PATCH v7 20/24] wfx: add scan.c/scan.h
Date: Fri, 01 Oct 2021 12:35:28 +0300 [thread overview]
Message-ID: <87r1d5krz3.fsf@codeaurora.org> (raw)
In-Reply-To: <20210920161136.2398632-21-Jerome.Pouiller@silabs.com> (Jerome Pouiller's message of "Mon, 20 Sep 2021 18:11:32 +0200")
Jerome Pouiller <Jerome.Pouiller@silabs.com> writes:
> From: Jérôme Pouiller <jerome.pouiller@silabs.com>
>
> Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
[...]
> +/* It is not really necessary to run scan request asynchronously. However,
> + * there is a bug in "iw scan" when ieee80211_scan_completed() is called before
> + * wfx_hw_scan() return
> + */
> +void wfx_hw_scan_work(struct work_struct *work)
> +{
> + struct wfx_vif *wvif = container_of(work, struct wfx_vif, scan_work);
> + struct ieee80211_scan_request *hw_req = wvif->scan_req;
> + int chan_cur, ret, err;
> +
> + mutex_lock(&wvif->wdev->conf_mutex);
> + mutex_lock(&wvif->scan_lock);
> + if (wvif->join_in_progress) {
> + dev_info(wvif->wdev->dev, "abort in-progress REQ_JOIN");
> + wfx_reset(wvif);
> + }
> + update_probe_tmpl(wvif, &hw_req->req);
> + chan_cur = 0;
> + err = 0;
> + do {
> + ret = send_scan_req(wvif, &hw_req->req, chan_cur);
> + if (ret > 0) {
> + chan_cur += ret;
> + err = 0;
> + }
> + if (!ret)
> + err++;
> + if (err > 2) {
> + dev_err(wvif->wdev->dev, "scan has not been able to start\n");
> + ret = -ETIMEDOUT;
> + }
> + } while (ret >= 0 && chan_cur < hw_req->req.n_channels);
> + mutex_unlock(&wvif->scan_lock);
> + mutex_unlock(&wvif->wdev->conf_mutex);
> + __ieee80211_scan_completed_compat(wvif->wdev->hw, ret < 0);
> +}
> +
> +int wfx_hw_scan(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
> + struct ieee80211_scan_request *hw_req)
> +{
> + struct wfx_vif *wvif = (struct wfx_vif *)vif->drv_priv;
> +
> + WARN_ON(hw_req->req.n_channels > HIF_API_MAX_NB_CHANNELS);
> + wvif->scan_req = hw_req;
> + schedule_work(&wvif->scan_work);
> + return 0;
> +}
This scan logic looks fishy to me, but no time to investigate in detail.
Though not a blocker.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-10-01 9:36 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 16:11 [PATCH v7 00/24] wfx: get out from the staging area Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 01/24] mmc: sdio: add SDIO IDs for Silabs WF200 chip Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 02/24] dt-bindings: introduce silabs,wfx.yaml Jerome Pouiller
2021-09-23 17:09 ` Rob Herring
2021-09-20 16:11 ` [PATCH v7 03/24] wfx: add Makefile/Kconfig Jerome Pouiller
2021-10-01 9:04 ` Kalle Valo
2021-10-01 9:06 ` Kalle Valo
2021-09-20 16:11 ` [PATCH v7 04/24] wfx: add wfx.h Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 05/24] wfx: add main.c/main.h Jerome Pouiller
2021-10-01 9:22 ` Kalle Valo
2021-10-01 9:44 ` Jérôme Pouiller
2021-10-01 12:18 ` Kalle Valo
2021-10-06 7:32 ` Jérôme Pouiller
2021-10-07 8:35 ` Kalle Valo
2021-10-07 10:00 ` Jérôme Pouiller
2021-10-07 10:41 ` Kalle Valo
2021-10-07 10:49 ` Kalle Valo
2021-10-07 11:22 ` Jérôme Pouiller
2021-11-10 9:58 ` Kalle Valo
2021-11-10 11:10 ` Jérôme Pouiller
2021-10-01 15:29 ` Jérôme Pouiller
2021-10-05 5:56 ` Kalle Valo
2021-10-05 8:12 ` Jérôme Pouiller
2021-09-20 16:11 ` [PATCH v7 06/24] wfx: add bus.h Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 07/24] wfx: add bus_spi.c Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 08/24] wfx: add bus_sdio.c Jerome Pouiller
2021-09-30 10:07 ` Ulf Hansson
2021-09-30 16:51 ` Jérôme Pouiller
2021-09-30 17:06 ` Pali Rohár
2021-10-01 15:23 ` Ulf Hansson
2021-10-05 8:14 ` Jérôme Pouiller
2021-10-06 15:02 ` Ulf Hansson
2021-10-06 15:42 ` Jérôme Pouiller
2021-10-07 8:26 ` Kalle Valo
2021-10-07 10:24 ` Pali Rohár
2021-10-01 15:37 ` Ulf Hansson
2021-10-05 5:59 ` Kalle Valo
2021-09-20 16:11 ` [PATCH v7 09/24] wfx: add hwio.c/hwio.h Jerome Pouiller
2021-10-01 9:52 ` Kalle Valo
2021-10-01 12:39 ` Kalle Valo
2021-09-20 16:11 ` [PATCH v7 10/24] wfx: add fwio.c/fwio.h Jerome Pouiller
2021-10-01 11:58 ` Kalle Valo
2021-10-01 15:09 ` Jérôme Pouiller
2021-10-01 16:08 ` Pali Rohár
2021-10-01 16:46 ` Jérôme Pouiller
2021-10-07 8:19 ` Kalle Valo
2021-10-07 10:10 ` Pali Rohár
2021-10-07 8:16 ` Kalle Valo
2021-10-07 10:13 ` Pali Rohár
2021-10-07 8:08 ` Kalle Valo
2021-10-07 9:35 ` Jérôme Pouiller
2021-09-20 16:11 ` [PATCH v7 11/24] wfx: add bh.c/bh.h Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 12/24] wfx: add hif_api_*.h Jerome Pouiller
2021-10-01 11:41 ` Kalle Valo
2021-10-01 11:52 ` Jérôme Pouiller
2021-10-01 12:45 ` Kalle Valo
2021-10-01 11:45 ` Kalle Valo
2021-10-01 11:48 ` Kalle Valo
2021-09-20 16:11 ` [PATCH v7 13/24] wfx: add hif_tx*.c/hif_tx*.h Jerome Pouiller
2021-10-01 9:55 ` Kalle Valo
2021-10-01 15:17 ` Jérôme Pouiller
2021-10-01 16:13 ` Pali Rohár
2021-10-05 6:12 ` Kalle Valo
2021-10-05 6:44 ` Greg Kroah-Hartman
2021-10-05 8:17 ` Jérôme Pouiller
2021-10-05 8:21 ` Greg Kroah-Hartman
2021-10-05 9:18 ` Jérôme Pouiller
2021-10-05 14:02 ` Jakub Kicinski
2021-09-20 16:11 ` [PATCH v7 14/24] wfx: add key.c/key.h Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 15/24] wfx: add hif_rx.c/hif_rx.h Jerome Pouiller
2021-10-01 10:09 ` Kalle Valo
2021-09-20 16:11 ` [PATCH v7 16/24] wfx: add data_rx.c/data_rx.h Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 17/24] wfx: add queue.c/queue.h Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 18/24] wfx: add data_tx.c/data_tx.h Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 19/24] wfx: add sta.c/sta.h Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 20/24] wfx: add scan.c/scan.h Jerome Pouiller
2021-10-01 9:35 ` Kalle Valo [this message]
2021-09-20 16:11 ` [PATCH v7 21/24] wfx: add debug.c/debug.h Jerome Pouiller
2021-10-01 12:01 ` Kalle Valo
2021-09-20 16:11 ` [PATCH v7 22/24] wfx: add traces.h Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 23/24] wfx: remove from the staging area Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 24/24] wfx: get out " Jerome Pouiller
2021-10-01 12:42 ` [PATCH v7 00/24] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1d5krz3.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Jerome.Pouiller@silabs.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pali@kernel.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).