From: Johannes Berg <johannes@sipsolutions.net>
To: vamsi krishna <vamsin@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, jouni@codeaurora.org
Subject: Re: [PATCH] nl80211/cfg80211: Add support to send tx frames at specified rate
Date: Tue, 18 Dec 2018 14:12:23 +0100 [thread overview]
Message-ID: <89e6532daf4011de2ad0df3dcb8accc42334f31e.camel@sipsolutions.net> (raw)
In-Reply-To: <1543838646-3574-1-git-send-email-vamsin@codeaurora.org>
On Mon, 2018-12-03 at 17:34 +0530, vamsi krishna wrote:
> NL80211_CMD_FRAME is used to send frames from userspace. Add support to
> transmit the frames at a rate specified by userspace when needed.
> The drivers shall indicate the support to send frames at rate specified
> by userspace by setting %NL80211_EXT_FEATURE_CMD_FRAME_TXRATE flag in
> wiphy capabilities. The userspace can specify the rate within
> %NL80211_ATTR_RATE_INFO attribute while sending %NL80211_CMD_FRAME.
>
> NL80211_ATTR_RATE_INFO is a nested attribute and encapsulates the
> attributes defined in &enum nl80211_rate_info.
It'd be good if you were to repost this with a driver that uses it.
Also, please explain why you think userspace needs this? It's not like
it can make better rate decisions than the rate control algorithm,
right?
> [NL80211_ATTR_SCHED_SCAN_MIN_RSSI] = { .type = NLA_NESTED },
> + [NL80211_ATTR_RATE_INFO] = { .type = NLA_NESTED },
This should use NLA_POLICY_NESTED(nl80211_rate_info_policy)
johannes
next prev parent reply other threads:[~2018-12-18 13:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 12:04 [PATCH] nl80211/cfg80211: Add support to send tx frames at specified rate vamsi krishna
2018-12-18 13:12 ` Johannes Berg [this message]
2018-12-18 13:45 ` Ben Greear
2019-01-08 17:22 ` [PATCH v2] nl80211/cfg80211: Add support to send tx packet specific params vamsi krishna
2019-01-25 12:48 ` Johannes Berg
2019-01-08 17:49 ` [PATCH] nl80211/cfg80211: Add support to send tx frames at specified rate vamsin
2019-01-08 20:21 ` Ben Greear
2019-01-15 13:13 ` Johannes Berg
2019-01-15 13:18 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89e6532daf4011de2ad0df3dcb8accc42334f31e.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jouni@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=vamsin@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).