From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AD5CC433DF for ; Mon, 17 Aug 2020 08:27:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 26C0320658 for ; Mon, 17 Aug 2020 08:27:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="WW6BjLlH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728133AbgHQI1i (ORCPT ); Mon, 17 Aug 2020 04:27:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728405AbgHQI0T (ORCPT ); Mon, 17 Aug 2020 04:26:19 -0400 Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77EBBC061389 for ; Mon, 17 Aug 2020 01:26:19 -0700 (PDT) Received: by mail-ed1-x544.google.com with SMTP id ba10so11586682edb.3 for ; Mon, 17 Aug 2020 01:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EB784NjPICkYR6SWnOZXgVJnpSq6x26Bh+bf4QaSgmE=; b=WW6BjLlHMZolL6jV9wGUJ2Nqna4uXwJlebSkTA9urlIi6Sa4Pa/NFLVlhsaFlRrn9E XQngChT6EYMcGX3cA8zMULqnTs8j60bTV+lfjDankwdHtdAkUKN1PbSGAMxLTWewd3c0 abf5dN1kL9l6jxvEgxS3raK9zw14TFbm9RQxo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EB784NjPICkYR6SWnOZXgVJnpSq6x26Bh+bf4QaSgmE=; b=oSjkZeiCdp+M/VuinHqztoCz/A4+ZN/GaRysj1T1bdyYOFcFVSykKz8imOg5dCz7ew 72oAlMp4y3ybqTqjxHBJJMkXIPLW7t8mKAQn92YcNR9UcqlBnXxmYvIjh0Sas0ST2yrj la+T03lqTgplg2BNI28rxoOWL79/bCzwkIHdVfc3g8S9vzUPEidP4bH6sJ/fx6qzpfFa DPFbq3Bzc0S66OtkI2+rXMzrsz2ndwtImoPBCHWauhjFHLY3igQyCjwU7LwtkdJcRYZ7 BoxBZkoUvizwLp85nwGZQJTZoHUp4xnFeL/SxAbz0wgY6lyNgaDBxDza3cSQpZUYEIpg v4DA== X-Gm-Message-State: AOAM530s5kkKe0OlIYiULA5Tf5BSiV5KoCo/PGxksiuoUbEfzJN3PnE0 tOiSVpY1TtFihovauc0At01g+Q== X-Google-Smtp-Source: ABdhPJxsKL8nm53WAnCAbGQdXqx/yIadsPW7nUTLAsMfgGi8OvTQ7NHOoDONUkkkyNaMHrIoZuYVvQ== X-Received: by 2002:a50:c3c4:: with SMTP id i4mr13899573edf.244.1597652778082; Mon, 17 Aug 2020 01:26:18 -0700 (PDT) Received: from [172.16.11.132] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id v13sm14170727edl.9.2020.08.17.01.26.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Aug 2020 01:26:17 -0700 (PDT) Subject: Re: [PATCH 08/30] net: wireless: ath: carl9170: Mark 'ar9170_qmap' as __maybe_unused To: Christian Lamparter , Lee Jones , davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, Christian Lamparter , Kalle Valo , Johannes Berg , linux-wireless@vger.kernel.org, netdev@vger.kernel.org References: <20200814113933.1903438-1-lee.jones@linaro.org> <20200814113933.1903438-9-lee.jones@linaro.org> <7ef231f2-e6d3-904f-dc3a-7ef82beda6ef@gmail.com> From: Rasmus Villemoes Message-ID: <9776eb47-6b83-a891-f057-dd34d14ea16e@rasmusvillemoes.dk> Date: Mon, 17 Aug 2020 10:26:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <7ef231f2-e6d3-904f-dc3a-7ef82beda6ef@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 14/08/2020 17.14, Christian Lamparter wrote: > On 2020-08-14 13:39, Lee Jones wrote: >> 'ar9170_qmap' is used in some source files which include carl9170.h, >> but not all of them.  Mark it as __maybe_unused to show that this is >> not only okay, it's expected. >> >> Fixes the following W=1 kernel build warning(s) > > Is this W=1 really a "must" requirement? I find it strange having > __maybe_unused in header files as this "suggests" that the > definition is redundant. In this case it seems one could replace the table lookup with a static inline u8 ar9170_qmap(u8 idx) { return 3 - idx; } gcc doesn't warn about unused static inline functions (or one would have a million warnings to deal with). Just my $0.02. Rasmus