linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: "Rémy Grünblatt" <remy@grunblatt.org>, linux-wireless@vger.kernel.org
Cc: linuxwifi@intel.com
Subject: Re: [PATCH] Minor corrections of comments in the iwlwifi mvm rate scaling source
Date: Wed, 17 Oct 2018 09:44:43 +0300	[thread overview]
Message-ID: <9f63350e8f853254adeb5eb6c280ec3cfe99409e.camel@coelho.fi> (raw)
In-Reply-To: <b403d919-57dd-aa2a-24f2-09d857cada5b@grunblatt.org>

On Thu, 2018-09-13 at 13:07 +0200, Rémy Grünblatt wrote:
> Hi,
> 
> I believe some comments in the rate scaling source of the iwlwifi mvm
> are wrong, as we have #define RATE_MCS_SGI_POS  13 and #define
> RATE_MCS_SGI_MSK  (1 << RATE_MCS_SGI_POS)

Hi Remy,

Sorry for the delay, your patch was not correctly formatted and since
this is a minor fix in a comment, it slipped through my fingers.

I have made a different patch to fix this, changing the hex values for
the tables instead, because in the example we say this is about SGI, so
I just set the SGI bit:

- * rate[0] 0x400D019 VHT | ANT: AB BW: 80Mhz MCS: 9 NSS: 2 SGI
- * rate[1] 0x400D019 VHT | ANT: AB BW: 80Mhz MCS: 9 NSS: 2 SGI
- * rate[2] 0x400D018 VHT | ANT: AB BW: 80Mhz MCS: 8 NSS: 2 SGI
- * rate[3] 0x400D018 VHT | ANT: AB BW: 80Mhz MCS: 8 NSS: 2 SGI
- * rate[4] 0x400D017 VHT | ANT: AB BW: 80Mhz MCS: 7 NSS: 2 SGI
- * rate[5] 0x400D017 VHT | ANT: AB BW: 80Mhz MCS: 7 NSS: 2 SGI
+ * rate[0] 0x400F019 VHT | ANT: AB BW: 80Mhz MCS: 9 NSS: 2 SGI
+ * rate[1] 0x400F019 VHT | ANT: AB BW: 80Mhz MCS: 9 NSS: 2 SGI
+ * rate[2] 0x400F018 VHT | ANT: AB BW: 80Mhz MCS: 8 NSS: 2 SGI
+ * rate[3] 0x400F018 VHT | ANT: AB BW: 80Mhz MCS: 8 NSS: 2 SGI
+ * rate[4] 0x400F017 VHT | ANT: AB BW: 80Mhz MCS: 7 NSS: 2 SGI
+ * rate[5] 0x400F017 VHT | ANT: AB BW: 80Mhz MCS: 7 NSS: 2 SGI


This is now queued in our internal tree and will reach the mainline at
some point, following our normal process.

Thanks for reporting.

--
Cheers,
Luca.


      reply	other threads:[~2018-10-17  6:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-13 11:07 [PATCH] Minor corrections of comments in the iwlwifi mvm rate scaling source Rémy Grünblatt
2018-10-17  6:44 ` Luca Coelho [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f63350e8f853254adeb5eb6c280ec3cfe99409e.camel@coelho.fi \
    --to=luca@coelho.fi \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linuxwifi@intel.com \
    --cc=remy@grunblatt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).