Re: [PATCH] ath10k: implement set_base_macaddr to fix rx-bssid mask in multiple APs conf

[Brian Norris <briannorris@chromium.org>]

On Mon, Feb 4, 2019 at 10:10 AM Christian Lamparter <chunkeey@gmail.com> wrote:
> On Monday, February 4, 2019 4:45:12 PM CET Kalle Valo wrote:
> > Christian Lamparter <chunkeey@gmail.com> writes:
> > > --- a/drivers/net/wireless/ath/ath10k/core.c
> > > +++ b/drivers/net/wireless/ath/ath10k/core.c
> > > @@ -2649,6 +2649,13 @@ int ath10k_core_start(struct ath10k *ar, enum ath10k_firmware_mode mode,
> > >             goto err_hif_stop;
> > >     }
> > >
> > > +   status = ath10k_wmi_pdev_set_base_macaddr(ar, ar->mac_addr);
> > > +   if (status) {
> > > +           ath10k_err(ar,
> > > +                      "failed to set base mac address: %d\n", status);
> > > +           goto err_hif_stop;
> > > +   }
> >
> > Oh, and as the new parameter is not supported with WMI TLV interface
> > (QCA6174, WCN3990 etc) this will print an error on those.
>
> This also means that Brian won't be able to test/verify this anyway?

Well, I'd be able to tell you if this started dumping new errors to the log :)

And in fact, it seems this crashes my firmware:

[  150.091401] qcom-q6v5-mss 4080000.remoteproc: fatal error received:
err_qdi.c:456:EF:wlan_process:1:cmnos_thread.c:3921:Asserted in
wlan_dev.c:WLAN_GET_MAC_ID_FROM_WMI_PDEV_ID:536

Note that I'm running WCN3990, and I haven't configure any sort of PD
restart -- so any WiFi firmware assertions/crashes take down the
entire modem/WiFi.

IOW:

Tested-and-found-wanting-by: Brian Norris <briannorris@chromium.org>

Willing to test a v2!

Regards,
Brian