linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Felix Fietkau <nbd@nbd.name>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/2] mt76: introduce mt76x02_check_tx_hang watchdog
Date: Thu, 27 Dec 2018 17:41:17 +0100	[thread overview]
Message-ID: <CAJ0CqmVJ_+djjWQ6YnUT7k_H1eauJ2hhy_4GB1jORQ-5bbvRAg@mail.gmail.com> (raw)
In-Reply-To: <20181227105909.GE25885@redhat.com>

>
> On Mon, Dec 24, 2018 at 05:24:42PM +0100, Lorenzo Bianconi wrote:
> > Port mt76x02_check_tx_hang watchdog from vendor driver in order to
> > perform a device reset when tx mac/dma logic hangs. Tx mac/dma stuck
> > has been observed when the device is heavily loaded or in a noisy
> > environment.
>
> On what hardware this happen ? Is this only for AP mode?

Hi Stanislaw,

I an able to trigger the issue using a mt7662 AP device till now, not
running STA or other modes yet.
I will respin this patch adding tx watchdog just on mt76x2 devices in
AP mode for the moment.

Regards,
Lorenzo

>
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c b/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c
> > index a4ff5a7a219f..402944e81e5e 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c
> > @@ -778,6 +778,90 @@ static void mt76x02_check_mac_err(struct mt76x02_dev *dev)
> >               MT_MAC_SYS_CTRL_ENABLE_TX | MT_MAC_SYS_CTRL_ENABLE_RX);
> >  }
> >
> > +static void mt76x02_mac_watchdog_reset(struct mt76x02_dev *dev)
>
> This all is MMIO specific, it should be moved to mt76x02_mmio.c
>
> Regards
> Stanislaw

      reply	other threads:[~2018-12-27 16:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-24 16:24 [PATCH 0/2] introduce mt76 tx hang watchdog Lorenzo Bianconi
2018-12-24 16:24 ` [PATCH 1/2] mt76: run mac work every 100ms Lorenzo Bianconi
2018-12-27 10:54   ` Stanislaw Gruszka
2018-12-27 16:44     ` Lorenzo Bianconi
2018-12-24 16:24 ` [PATCH 2/2] mt76: introduce mt76x02_check_tx_hang watchdog Lorenzo Bianconi
2018-12-27 10:59   ` Stanislaw Gruszka
2018-12-27 16:41     ` Lorenzo Bianconi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ0CqmVJ_+djjWQ6YnUT7k_H1eauJ2hhy_4GB1jORQ-5bbvRAg@mail.gmail.com \
    --to=lorenzo.bianconi@redhat.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@nbd.name \
    --cc=sgruszka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).