From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Christina Quast <contact@christina-quast.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>,
Eric Biggers <ebiggers@google.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"open list:ANDROID DRIVERS" <devel@driverdev.osuosl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Anushka Shukla <anushkacharu9@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Zach Turner <turnerzdp@gmail.com>,
"<linux-wireless@vger.kernel.org>"
<linux-wireless@vger.kernel.org>,
Johannes Berg <johannes@sipsolutions.net>,
"David S. Miller" <davem@davemloft.net>,
"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>
Subject: Re: [PATCH 0/2] Use ccm(aes) aead transform in staging drivers
Date: Fri, 16 Aug 2019 11:31:23 +0300 [thread overview]
Message-ID: <CAKv+Gu-qbwCJzH2TMpe5hEh8UAO3XQ66Zzf9Nx4UqBXd3Lr79w@mail.gmail.com> (raw)
In-Reply-To: <20190816065936.12214-1-contact@christina-quast.de>
On Fri, 16 Aug 2019 at 10:00, Christina Quast
<contact@christina-quast.de> wrote:
>
> Use ccm(aes) aead transform instead of invoking the AES block cipher
> block by block.
>
Thanks! This eliminates another two users of the bare cipher API,
which is not the right abstraction for drivers to use.
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
I don't have the hardware, so I can't test this.
> Christina Quast (2):
> staging: rtl8192u: ieee80211: ieee80211_crypt_ccmp.c: Use crypto API
> ccm(aes)
> staging: rtl8192e: rtllib_crypt_ccmp.c: Use crypto API ccm(aes)
>
> drivers/staging/rtl8192e/Kconfig | 1 +
> drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 187 ++++++++----------
> drivers/staging/rtl8192u/Kconfig | 2 +
> .../rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 187 ++++++++----------
> 4 files changed, 159 insertions(+), 218 deletions(-)
>
> --
> 2.20.1
>
prev parent reply other threads:[~2019-08-16 8:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 6:59 [PATCH 0/2] Use ccm(aes) aead transform in staging drivers Christina Quast
2019-08-16 6:59 ` [PATCH 1/2] staging: rtl8192u: ieee80211: ieee80211_crypt_ccmp.c: Use crypto API ccm(aes) Christina Quast
2019-08-16 6:59 ` [PATCH 2/2] staging: rtl8192e: rtllib_crypt_ccmp.c: " Christina Quast
2019-08-19 17:57 ` Larry Finger
2019-08-16 8:31 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu-qbwCJzH2TMpe5hEh8UAO3XQ66Zzf9Nx4UqBXd3Lr79w@mail.gmail.com \
--to=ard.biesheuvel@linaro.org \
--cc=anushkacharu9@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=contact@christina-quast.de \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=ebiggers@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=johannes@sipsolutions.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=payal.s.kshirsagar.98@gmail.com \
--cc=turnerzdp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).