From: Rob Herring <robh@kernel.org>
To: equu@openmail.cc
Cc: lpieralisi@kernel.org, toke@toke.dk, kvalo@kernel.org,
linux-pci@vger.kernel.org, linux-wireless@vger.kernel.org,
ath10k@lists.infradead.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v5 3/3] wifi: ath10k: only load compatible DT cal data
Date: Fri, 3 Feb 2023 12:45:13 -0600 [thread overview]
Message-ID: <CAL_JsqLbGBQcxDQSbsqFyE2CR3VH=61NtZvU2YqE1visdUZXCQ@mail.gmail.com> (raw)
In-Reply-To: <aef1d48b-cfc2-1a5d-d26c-deae85875d43@openmail.cc>
On Fri, Feb 3, 2023 at 11:15 AM <equu@openmail.cc> wrote:
>
> > I think this can be done a bit cleaner and like other drivers. I see 2 options.
> > The first way is use VID/PID compatible strings and don't set the
> > of_node pointer if there is a mismatch.
> Where should I do this? In pci_set_of_node() from drivers/pci/of.c?
Off the top of my head, I think so.
> > Upon further thought, why can't you decide all this just on PCI
> > VID/PID? The giant switch statement in ath10k_pci_probe() could all
> > just be struct of driver_data from the PCI match table.
>
> I cannot decide all this just on PCI VID/PID because PCI VID/PID cannot tell whether calibration data are stored in the device (like most expansion cards) or not (for example, in an NVRAM cell referenced by the device tree).
>
For a given VID/PID, you could have calibration data in DT that you
want to ignore sometimes and not other times (because the compatible
is wrong)?
Rob
next prev parent reply other threads:[~2023-02-03 18:45 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ea4e2fed-383d-829d-8a2a-9239768ccd94@openmail.cc>
2023-01-17 9:27 ` [PATCH 1/3] PCI: of: Match pci devices or drivers against OF DT nodes Edward Chow
2023-01-17 9:27 ` [PATCH 2/3] wifi: ath9k: stop loading incompatible DT cal data Edward Chow
2023-01-17 19:46 ` Bjorn Helgaas
2023-02-01 3:02 ` Mad Horse
2023-02-01 21:43 ` Bjorn Helgaas
2023-02-02 4:18 ` [PATCH v2 0/3] PCI: of: Load extra data only from compatible DT nodes equu
2023-02-02 4:18 ` [PATCH v2 1/3] PCI: of: Match pci devices or drivers against OF " equu
2023-02-02 4:18 ` [PATCH v2 2/3] wifi: ath9k: stop loading incompatible DT cal data equu
2023-02-02 4:18 ` [PATCH v2 3/3] wifi: ath10k: only load compatible " equu
2023-02-02 7:26 ` kernel test robot
2023-02-02 7:55 ` [PATCH v3 0/3] PCI: of: Load extra data only from compatible DT nodes equu
2023-02-02 7:55 ` [PATCH v3 1/3] PCI: of: Match pci devices or drivers against OF " equu
2023-02-03 8:23 ` kernel test robot
2023-02-02 7:55 ` [PATCH v3 2/3] wifi: ath9k: stop loading incompatible DT cal data equu
2023-02-03 9:56 ` kernel test robot
2023-02-02 7:55 ` [PATCH v3 3/3] wifi: ath10k: only load compatible " equu
2023-02-03 11:38 ` kernel test robot
2023-02-03 8:37 ` [PATCH v4 0/3] PCI: of: Load extra data only from compatible DT nodes equu
2023-02-03 8:37 ` [PATCH v4 1/3] PCI: of: Match pci devices or drivers against OF " equu
2023-02-03 8:37 ` [PATCH v4 2/3] wifi: ath9k: stop loading incompatible DT cal data equu
2023-02-03 8:37 ` [PATCH v4 3/3] wifi: ath10k: only load compatible " equu
2023-02-03 10:48 ` [PATCH v5 0/3] PCI: of: Load extra data only from compatible DT nodes equu
2023-02-03 10:48 ` [PATCH v5 1/3] PCI: of: Match pci devices or drivers against OF " equu
2023-02-03 10:48 ` [PATCH v5 2/3] wifi: ath9k: stop loading incompatible DT cal data equu
2023-02-03 10:48 ` [PATCH v5 3/3] wifi: ath10k: only load compatible " equu
2023-02-03 15:57 ` Rob Herring
2023-02-03 17:15 ` equu
2023-02-03 18:45 ` Rob Herring [this message]
2023-02-04 4:26 ` equu
2023-02-09 4:50 ` [PATCH v6 0/3] PCI: of: Load extra data only from compatible DT nodes equu
2023-02-09 4:50 ` [PATCH v6 1/3] PCI: of: Match pci devices or drivers against OF " equu
2023-02-09 4:50 ` [PATCH v6 2/3] wifi: ath9k: stop loading incompatible DT cal data equu
2023-02-09 4:50 ` [PATCH v6 3/3] wifi: ath10k: only load compatible " equu
2023-02-09 16:09 ` Rob Herring
2023-01-17 9:28 ` [PATCH " Edward Chow
2023-01-17 10:01 ` [PATCH 1/3] PCI: of: Match pci devices or drivers against OF DT nodes Mad Horse
2023-01-17 10:02 ` [PATCH 2/3] wifi: ath9k: stop loading incompatible DT cal data Mad Horse
2023-01-17 10:02 ` [PATCH 3/3] wifi: ath10k: only load compatible " Mad Horse
2023-01-17 10:29 ` [PATCH 1/3] PCI: of: Match pci devices or drivers against OF DT nodes Mad Horse
2023-01-21 10:00 ` [PATCH 2/3] wifi: ath9k: stop loading incompatible DT cal data persmule
2023-01-21 10:06 ` [PATCH 3/3] wifi: ath10k: only load compatible " persmule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqLbGBQcxDQSbsqFyE2CR3VH=61NtZvU2YqE1visdUZXCQ@mail.gmail.com' \
--to=robh@kernel.org \
--cc=ath10k@lists.infradead.org \
--cc=equu@openmail.cc \
--cc=kvalo@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lpieralisi@kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).