Re: mt76x[02]u 802.11w support

[Sid Hayn <sidhayn@gmail.com>]

On Wed, Dec 19, 2018 at 2:47 AM Stanislaw Gruszka <sgruszka@redhat.com> wrote:
>
> On Tue, Dec 18, 2018 at 01:38:54PM -0500, Sid Hayn wrote:
> > > > Regarding this case, there is no single commit that add 802.11w support
> > > > we could request to add to -stable. It was added together with other
> > > > features in:
> > > >
> > > > commit 0ae976a11b4fb5704b597e103b5189237641c1a1
> > > > Author: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> > > > Date:   Thu Sep 6 11:18:41 2018 +0200
> > > >
> > > >     mt76x0: init hw capabilities
> > > >
> > > > which depend on switching mt76x0u to mt76-usb layer.
> > > >
> > > > So I'm not sure how this request should be satisfied.
> > >
> > > Can you check if adding
> > >
> > > ieee80211_hw_set(rt2x00dev->hw, MFP_CAPABLE);
> > In this case I inferred from cotext that it should be
> > ieee80211_hw_set(hw, MFP_CAPABLE); hopefully that is correct.
>
> Yeah it is. I copied the line from wrong driver :-)
>
> > > is sufficient to add support for 802.11w ?
> > As a matter of fact it was sufficient.  I can now connect to my AP
> > with 802.11w required and prior to this one line change I could not.
> > Thanks for taking the time to suggest this, it seems to work well
> > enough to connect.  I don't much have a means to test to see if deauth
> > frames are properly handled, do you have any test cases you want to
> > suggest or are you comfortable enough that it should work properly?
>
> If you using wpa_supplicant, 'wpa_cli disconnect' should
> trigger deauth exchange.
politely killing wpa_supplicant also triggers deauth.  it didn't error
when it did so, so I'll assume it was happy.
>
> Are there errors in dmesg ? If there are many errors, I think
> we will need to change EINVAL to EOPNOTSUPP as well.

dmesg appears clean.

Thanks,
Zero
>
> Thanks
> Stanislaw