linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Július Milan" <jmilan.dev@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-wireless@vger.kernel.org, gregkh@linuxfoundation.org,
	ajay.kathat@microchip.com, adham.abozaeid@microchip.com
Subject: Re: [PATCH v2] staging: wilc1000: fix cast to restricted __le32
Date: Sun, 6 Jan 2019 08:18:53 +0100	[thread overview]
Message-ID: <CAP=P++DRiM8Rb8vg9hBJ-N2uhfL0Rrj+njYwgZW80yQZ4jQH4g@mail.gmail.com> (raw)
In-Reply-To: <61a272a5-3c6f-4e69-2ce9-b7c58b427750@lwfinger.net>

Thank you for your review Larry

> Before you send V3

Oh, v3 was already sent a few moments before your message.

> Before you send V3, are you sure this is the correct fix? As "frame_type" is
> input as u16, it seems to me that the frame_type member of struct wilc_reg_frame
> should be __le16, not __le32.

Yes, I am confident about it.
The frame_type member of struct wilc_reg_frame contains in some cases
32 bit value
as you can see in function wilc_wlan_cfg_set_wid.
Cast to 32 bits is also safe, due to resultant endianness.

Julius

  reply	other threads:[~2019-01-06  7:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-05  9:10 [PATCH v2] staging: wilc1000: fix cast to restricted __le32 Július Milan
2019-01-05  9:16 ` Greg KH
2019-01-05 16:02 ` Larry Finger
2019-01-06  7:18   ` Július Milan [this message]
2019-01-07  6:06     ` Ajay.Kathat
2019-01-07 14:48       ` Július Milan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP=P++DRiM8Rb8vg9hBJ-N2uhfL0Rrj+njYwgZW80yQZ4jQH4g@mail.gmail.com' \
    --to=jmilan.dev@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=adham.abozaeid@microchip.com \
    --cc=ajay.kathat@microchip.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).