From: Johannes Berg <johannes@sipsolutions.net>
To: Alexander Wetzel <alexander@wetzel-home.de>
Cc: linux-wireless@vger.kernel.org, mpubbise@codeaurora.org
Subject: Re: [PATCH] mac80211: Honor SW_CRYPTO_CONTROL in AP VLAN mode
Date: Mon, 08 Apr 2019 14:09:10 +0200 [thread overview]
Message-ID: <ad27a4098892dbd2ebd1954ba6f34ae0fea4600c.camel@sipsolutions.net> (raw)
In-Reply-To: <20190209140138.16692-1-alexander@wetzel-home.de>
On Sat, 2019-02-09 at 15:01 +0100, Alexander Wetzel wrote:
> Restore @SW_CRYPTO_CONTROL when interface is in AP Vlan mode and don't
> override driver decision for unicast keys.
>
> Fixes commit db3bdcb9c3ff ("mac80211: allow AP_VLAN operation on crypto
> controlled devices"), which should only have allow SW crypto fallback for
> group keys.
This confuses me.
The driver doesn't really know about AP_VLAN, so the original commit
intentionally did this, I think?
There was some kind of other fix related to this though?
johannes
next prev parent reply other threads:[~2019-04-08 12:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-09 14:01 [PATCH] mac80211: Honor SW_CRYPTO_CONTROL in AP VLAN mode Alexander Wetzel
2019-04-08 12:09 ` Johannes Berg [this message]
2019-04-08 19:58 ` Alexander Wetzel
2019-04-09 11:37 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad27a4098892dbd2ebd1954ba6f34ae0fea4600c.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=alexander@wetzel-home.de \
--cc=linux-wireless@vger.kernel.org \
--cc=mpubbise@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).