From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E642EC76186 for ; Mon, 29 Jul 2019 05:44:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BFF892070B for ; Mon, 29 Jul 2019 05:44:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=gmx.net header.i=@gmx.net header.b="Q2TWJP12" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726757AbfG2FoZ (ORCPT ); Mon, 29 Jul 2019 01:44:25 -0400 Received: from mout.gmx.net ([212.227.17.22]:41249 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725988AbfG2FoY (ORCPT ); Mon, 29 Jul 2019 01:44:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1564379045; bh=CFTAnV+JKG1Y4wZfBtZhC5MNxxIlU1OdRc/wca9swZI=; h=X-UI-Sender-Class:Subject:From:To:Cc:References:Date:In-Reply-To; b=Q2TWJP129E9FI/uW74sw1N9Rdr9V+ia/aUCXERiUHfO+1Aay4fGh78qCWpDjvkoFR cSNsjucIDRInZc8OdQ+eQYThjiOJnNbp+gGuKHrkV6z33YVvo7AVLDQYHpkuKQfCF4 2zuF/rFfK/PwSOIt7Mm3W1nQMLmQwUl03FLZ0/PE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.162] ([37.4.249.117]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0M7H2Y-1icf9n2BBG-00x4Rs; Mon, 29 Jul 2019 07:44:05 +0200 Subject: Re: brcmfmac: Probing regression in Linux 5.3-rc1 From: Stefan Wahren To: Nicolas Saenz Julienne , Chen-Yu Tsai Cc: linux-arm-kernel , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , "linux-wireless@vger.kernel.org" , brcm80211-dev-list , Johannes Berg References: <1563774880-8061-1-git-send-email-wahrenst@gmx.net> <96113adb5fcab9c2f4bb5fa82b84ff5f9c07fd07.camel@suse.de> <20190723093442.GA27239@lst.de> <04c5eaa03f3a124dbbce6186e11e19acc4539cc8.camel@suse.de> <5f9b11f54c66fd0487837f7e58af3adf7f86635f.camel@suse.de> <3daef629-8baf-3c5c-16a4-73d67604d1e5@gmx.net> Message-ID: Date: Mon, 29 Jul 2019 07:44:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <3daef629-8baf-3c5c-16a4-73d67604d1e5@gmx.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Provags-ID: V03:K1:bhg3HeZuoRPTYEoKMN6P+ztFVo4zA66p1dLMelZKYN2RzT/yKNL 7su6G+fId0SNYqszVj5J21ijlkL4cJuRQh0Z+Ya906DdMGtZ9sqKKlTe0dGOWp4Iq8OXJK3 jj2b3ldOxJbNFj2xCpS4sh3ZHOCAxGfLPwDnyq6K4daMO+zHALut0hiKJn7NOXlN5Wx/nfp CyzYoI/R5eWuOuUMmSG8w== X-UI-Out-Filterresults: notjunk:1;V03:K0:xO7C9DBpyRU=:Rd/HvVSqBH2dDX9pXNd3Yj SBbeY5w5cznqeK+jaud9e5M1sCMSkKppoIT5czdGaNFJ2jn6OKtlXthnf7RGyqkvfBTo5ZFsN Vtd9eIztODAoR9qhAesXsS7p5OTl+/+Gp/PuIsC4WEAGXreTY4jNF0xUtP1oKfPrkvEv97mJH 3fdNGIxQhAD8dgGxU3O4uMuNKdsXLmb2xlJvET9Q/G32PaT60dx2FUNjP/49L3X+50zt9QFvE 4MQxWmR2u2FFvEJZ845/hdN5PTEb49JzU3yjbNsQyTS+BXzeKfrDl0y9BuD3usonRTMSt3Us3 ngmu4YsPPGPT/UBtmbAHReg+Y1pV+Mm+C+ZRoNLBJ22mn3kRxgob0XYyj6gg29q5DOMGgxbyx 8tQ1KGwK8DiPLpqpDIC4PML/lVCSVGGYhYuhqo510EZVzFlRn1qsIQYB1Em5EB9mmj1QJ6jZ1 Y/QvbPqJQ2tPBRPtBgxXINVcPHUnuUaLD9vJVW7/XoPrE63TtKGNydQmg+KJjBJKJnw+84UhW tT3zwNwt0p+296FxhvJj3VsujUt1kUyGrbZZO4/DyOVBA1YEEBL5wt+c55w0ZxCT977Npv+E8 FCqxBkqHkGDAkLunbT16iR05ECLtm3S89OAh8rqMELk4fYTQWHBMHa69j2ytDaCoXYy5ju1L+ JV2ngB7BZ63oIlCjSYGhtVPmzB3fNFG4+namYeq4e4HXYQj33t95KlzmOstwTS4WIcot4O+JJ lA/E6lX0MqNrUBTpiqj4bEEYStCYTJpMTXoikgXxe4DLiBHkV9DaIkjI9/GZyAkinDynGaA/U aP1jzvJGI1YTgvwCP7av6TsBfM0SjRHro4ufla9lgPrVee3xnVTNVAHCQ6IW4oAGDCbJNmY2A SujzDSAEn3HSW606JGq4qko6JZDefChG5K1Falnqd/aVUfGRARakivSlmuYYWo3qHCC+0X5kP J848s8xsB8BRf4eQBa4z92ccTa108AcveIhPVQGNN6vw4NC2iNkeodxNS94OzePe2Jh+pZrU9 ElhOi6XCRtaTJnSF/wVnMlzhfwMnv/eMix2krILF0dPHQB1jJ8Y2Zxp00MOdMY+umDVJSxK4b 8xRNWh8z1XQscw= Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi, Am 27.07.19 um 17:17 schrieb Stefan Wahren: > Hi, > > Am 24.07.19 um 10:37 schrieb Nicolas Saenz Julienne: >>>>> Does it fix the wifi issue too? >>>> Well it works as long as I revert this: 901bb98918 ("nl80211: require and >>>> validate vendor command policy"). Which has nothing to do with DMA anyways. >>>> >>>> Was this the issue you where seeing? >>>> >>>> [ 4.969679] WARNING: CPU: 2 PID: 21 at net/wireless/core.c:868 >>>> wiphy_register+0x8e8/0xbdc [cfg80211] >>>> [...] >>>> [ 4.969974] ieee80211 phy0: brcmf_cfg80211_attach: Could not register >>>> wiphy device (-22) >>> We're seeing this on different platforms (allwinner / rockchip / amlogic) >>> with Broadcom WiFi chips. So it's unlikely to be related with anything in >>> this series. >>> >>> I believe a fix for this has already been queued up: >>> >>> >> https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git/commit/?id=91046d6364afde646734c7ead1f649d253c386e9 >> >> Thanks for pointing it out, it fixes the issue alright. >> > i cannot confirm. I still need to revert Johannes' commit "nl80211: > require and validate vendor command policy" to get brcmfmac probing on > Raspberry Pi 3B+ and 4B. > > The commit "nl80211: fix VENDOR_CMD_RAW_DATA" didn't fix the probing > issue (see warning above). i rebased my series on top of Linux 5.3-rc2 and issue disappeared. I assume the commit "wireless: fix nl80211 vendor commands" is also required. Sorry, for the noise. > > Regards > Stefan > >