From: Johannes Berg <johannes@sipsolutions.net>
To: Narayanraddi Masti <team.nmasti@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mac8011: Add support for NL80211_STA_INFO_RX_MCAST_BCAST
Date: Mon, 08 Apr 2019 14:02:08 +0200 [thread overview]
Message-ID: <c852f186800a24a80353f7a9b1a882fb1f25f2da.camel@sipsolutions.net> (raw)
In-Reply-To: <1549570566-28658-2-git-send-email-team.nmasti@gmail.com> (sfid-20190207_211547_441291_33DCE17E)
On Thu, 2019-02-07 at 12:16 -0800, Narayanraddi Masti wrote:
> Add support to collect per STA mcast/bcast packet information attribute
> NL80211_STA_INFO_RX_MCAST_BCAST.
This, honestly, I'm not a fan of.
We've added far too many statistics already, and we keep adding more.
This, in particular, also adds a bunch of 64-bit counters (is that
really needed?) which is relatively expensive on 32-bit platforms, and
it didn't even update the fast-RX path properly.
I really think we need to stick some eBPF hooks somewhere late enough to
get valid data, but early enough to get all the data, and then you can
keep all your favourite statistics there.
johannes
next prev parent reply other threads:[~2019-04-08 12:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 20:16 [PATCH 1/2] mac80211: Add support for NL80211_STA_INFO_AIRTIME_LINK_METRIC Narayanraddi Masti
2019-02-07 20:16 ` [PATCH 2/2] mac8011: Add support for NL80211_STA_INFO_RX_MCAST_BCAST Narayanraddi Masti
2019-04-08 12:02 ` Johannes Berg [this message]
2019-04-08 11:59 ` [PATCH 1/2] mac80211: Add support for NL80211_STA_INFO_AIRTIME_LINK_METRIC Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2019-02-07 20:13 Narayanraddi Masti
2019-02-07 20:13 ` [PATCH 2/2] mac8011: Add support for NL80211_STA_INFO_RX_MCAST_BCAST Narayanraddi Masti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c852f186800a24a80353f7a9b1a882fb1f25f2da.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=team.nmasti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).