From: Ben Greear <greearb@candelatech.com>
To: Shayne Chen <shayne.chen@mediatek.com>, Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
Ryder Lee <ryder.lee@mediatek.com>,
Evelyn Tsai <evelyn.tsai@mediatek.com>,
linux-mediatek <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v5 1/8] mt76: mt7915: introduce mt7915_mcu_beacon_check_caps()
Date: Thu, 7 Oct 2021 16:50:41 -0700 [thread overview]
Message-ID: <dbe9af7e-dd5a-827b-aedc-c0fa767faf05@candelatech.com> (raw)
In-Reply-To: <20211001095355.10598-1-shayne.chen@mediatek.com>
On 10/1/21 2:53 AM, Shayne Chen wrote:
> From: Ryder Lee <ryder.lee@mediatek.com>
>
> Beacon elements might be changed by hostapd configuraion, so driver
> should compare both IEs and PHY capabilities to get the least common
> denominator before association.
>
> Co-developed-by: Evelyn Tsai <evelyn.tsai@mediatek.com>
> Signed-off-by: Evelyn Tsai <evelyn.tsai@mediatek.com>
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
> ---
> v2: modify condition for mimo_dl_en
> v5: rebase to staging tree
Have you tested this in station mode? I tried merging this into my tree
and it broke station mode. Symptom was that it associated, but could not
get DHCP. It worked if I disabled AX mode and made it associate as 11ac.
I think root cause is probably that the beacon is never set in STA mode,
but the code building the MCU messages are unconditionally looking at
the values derived from the beacon caps when making decisions about bfer/bfee
and ldpc and such.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
prev parent reply other threads:[~2021-10-07 23:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 9:53 [PATCH v5 1/8] mt76: mt7915: introduce mt7915_mcu_beacon_check_caps() Shayne Chen
2021-10-01 9:53 ` [PATCH v5 2/8] mt76: mt7915: fix txbf starec TLV issues Shayne Chen
2021-10-01 9:53 ` [PATCH v5 3/8] mt76: mt7915: improve starec readability of txbf Shayne Chen
2021-10-01 9:53 ` [PATCH v5 4/8] mt76: mt7915: fix sta_rec_wtbl tag len Shayne Chen
2021-10-09 19:03 ` Kalle Valo
2021-10-01 9:53 ` [PATCH v5 5/8] mt76: mt7915: rework starec TLV tags Shayne Chen
2021-10-01 9:53 ` [PATCH v5 6/8] mt76: mt7915: fix muar_idx in mt7915_mcu_alloc_sta_req() Shayne Chen
2021-10-09 19:04 ` Kalle Valo
2021-10-01 9:53 ` [PATCH v5 7/8] mt76: mt7915: set VTA bit in tx descriptor Shayne Chen
2021-10-01 9:53 ` [PATCH v5 8/8] mt76: mt7915: set muru platform type Shayne Chen
2021-10-07 23:50 ` Ben Greear [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbe9af7e-dd5a-827b-aedc-c0fa767faf05@candelatech.com \
--to=greearb@candelatech.com \
--cc=evelyn.tsai@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=ryder.lee@mediatek.com \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).