From: Johannes Berg <johannes@sipsolutions.net>
To: Fredrik Olofsson <fredrik.olofsson@anyfinetworks.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: fix overwriting of qos_ctrl.tid field
Date: Fri, 22 Nov 2019 13:00:32 +0100 [thread overview]
Message-ID: <e28361a05a275e999be17eb7ce659423db255497.camel@sipsolutions.net> (raw)
In-Reply-To: <20191119133451.14711-1-fredrik.olofsson@anyfinetworks.com> (sfid-20191119_143525_400237_AC0E3C8B)
On Tue, 2019-11-19 at 14:34 +0100, Fredrik Olofsson wrote:
> Fixes overwriting of qos_ctrl.tid field for encrypted frames injected on
> monitor interface. qos_ctrl.tid is protected by the encryption, and
> cannot be modified after encryption. For injected frames, the encryption
> key may not be available.
>
> Before passing the frame to the driver, the qos_ctrl.tid field is
> updated from skb->priority. Prior to dbd50a851c50 skb->priority was
> updated in ieee80211_select_queue_80211(), but this function is no longer
> always called. This patch tries to mimmic the previous behaviour by
> updating skb->priority in ieee80211_monitor_start_xmit().
I'm not sure I understand.
If the QoS field is overwritten (where, btw?) then wouldn't that still
be done even after this change, and if the frame is pre-encrypted it is
corrupted?
johannes
next prev parent reply other threads:[~2019-11-22 12:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 13:34 [PATCH] mac80211: fix overwriting of qos_ctrl.tid field Fredrik Olofsson
2019-11-22 12:00 ` Johannes Berg [this message]
2019-11-22 15:06 ` Fredrik Olofsson
2019-11-22 17:50 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e28361a05a275e999be17eb7ce659423db255497.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=fredrik.olofsson@anyfinetworks.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).