From: Johannes Berg <johannes@sipsolutions.net>
To: Denis Kenzior <denkenz@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/3] nl80211: Include wiphy address setup in NEW_WIPHY
Date: Thu, 20 Jun 2019 08:58:49 +0200 [thread overview]
Message-ID: <ec1ca95a5789f9001e89e603633b20316d687721.camel@sipsolutions.net> (raw)
In-Reply-To: <20190619223606.4575-3-denkenz@gmail.com> (sfid-20190620_003639_356445_BEE1812F)
Didn't really review all of this yet, but
switch (state->split_start) {
> case 0:
> + if (nla_put(msg, NL80211_ATTR_MAC, ETH_ALEN,
> + rdev->wiphy.perm_addr))
> + goto nla_put_failure;
We generally can't add anything to any of the cases before the split was
allowed, for compatibility with old userspace.
johannes
next prev parent reply other threads:[~2019-06-20 6:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 22:36 [PATCH 1/3] nl80211: Update uapi for CMD_FRAME_WAIT_CANCEL Denis Kenzior
2019-06-19 22:36 ` [PATCH 2/3] nl80211: Limit certain commands to interface owner Denis Kenzior
2019-06-27 8:55 ` [nl80211] d8572a564d: assertion_failed kernel test robot
2019-06-19 22:36 ` [PATCH 3/3] nl80211: Include wiphy address setup in NEW_WIPHY Denis Kenzior
2019-06-20 6:58 ` Johannes Berg [this message]
2019-06-20 16:16 ` Denis Kenzior
2019-06-20 19:17 ` Johannes Berg
2019-06-20 20:05 ` Denis Kenzior
2019-06-20 20:09 ` Johannes Berg
2019-06-20 20:21 ` Johannes Berg
2019-06-20 23:51 ` Denis Kenzior
2019-06-20 20:35 ` Denis Kenzior
2019-06-20 7:50 ` [PATCH 1/3] nl80211: Update uapi for CMD_FRAME_WAIT_CANCEL Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec1ca95a5789f9001e89e603633b20316d687721.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=denkenz@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).