From: Takashi Iwai <tiwai@suse.de>
To: Brian Norris <briannorris@chromium.org>
Cc: Ganapathi Bhat <gbhat@marvell.com>,
Nishant Sarmukadam <nishants@marvell.com>,
Amitkumar Karwar <amitkarwar@gmail.com>,
Xinming Hu <huxinming820@gmail.com>,
<linux-kernel@vger.kernel.org>,
linux-wireless@vger.kernel.org, Takashi Iwai <tiwai@suse.de>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 5.2 1/2] mwifiex: Don't abort on small, spec-compliant vendor IEs
Date: Mon, 17 Jun 2019 08:12:22 +0200 [thread overview]
Message-ID: <s5h8su0d9kp.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190615001321.241808-1-briannorris@chromium.org>
On Sat, 15 Jun 2019 02:13:20 +0200,
Brian Norris wrote:
>
> Per the 802.11 specification, vendor IEs are (at minimum) only required
> to contain an OUI. A type field is also included in ieee80211.h (struct
> ieee80211_vendor_ie) but doesn't appear in the specification. The
> remaining fields (subtype, version) are a convention used in WMM
> headers.
>
> Thus, we should not reject vendor-specific IEs that have only the
> minimum length (3 bytes) -- we should skip over them (since we only want
> to match longer IEs, that match either WMM or WPA formats). We can
> reject elements that don't have the minimum-required 3 byte OUI.
>
> While we're at it, move the non-standard subtype and version fields into
> the WMM structs, to avoid this confusion in the future about generic
> "vendor header" attributes.
>
> Fixes: 685c9b7750bf ("mwifiex: Abort at too short BSS descriptor element")
> Cc: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
> It appears that commit 685c9b7750bf is on its way to 5.2, so I labeled
> this bugfix for 5.2 as well.
Thanks for catching this.
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Takashi
next prev parent reply other threads:[~2019-06-17 6:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-15 0:13 [PATCH 5.2 1/2] mwifiex: Don't abort on small, spec-compliant vendor IEs Brian Norris
2019-06-15 0:13 ` [PATCH 2/2] mwifiex: use 'total_ie_len' in mwifiex_update_bss_desc_with_ie() Brian Norris
2019-06-17 6:14 ` Takashi Iwai
2019-06-25 4:51 ` Kalle Valo
2019-10-01 9:22 ` Kalle Valo
2019-06-17 6:12 ` Takashi Iwai [this message]
2019-06-24 13:23 ` [PATCH 5.2 1/2] mwifiex: Don't abort on small, spec-compliant vendor IEs Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h8su0d9kp.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=amitkarwar@gmail.com \
--cc=briannorris@chromium.org \
--cc=gbhat@marvell.com \
--cc=huxinming820@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).