Re: [PATCH wpan-next 2/3] ieee802154: Handle coordinators discovery

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Alexander Aring <aahringo@redhat.com>
Cc: Alexander Aring <alex.aring@gmail.com>,
	Stefan Schmidt <stefan@datenfreihafen.org>,
	linux-wpan@vger.kernel.org,
	David Girault <david.girault@qorvo.com>,
	Romuald Despres <romuald.despres@qorvo.com>,
	Frederic Blain <frederic.blain@qorvo.com>,
	Nicolas Schodet <nico@ni.fr.eu.org>,
	Guilhem Imberton <guilhem.imberton@qorvo.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH wpan-next 2/3] ieee802154: Handle coordinators discovery
Date: Mon, 7 Nov 2022 09:43:48 +0100	[thread overview]
Message-ID: <20221107094348.72223dc8@xps-13> (raw)
In-Reply-To: <CAK-6q+hh4Ny7zV-MbdjrGQq-Dtb783A8m3G5GMcXSdhSwicuiw@mail.gmail.com>

Hi Alexander,

> > +static bool
> > +cfg802154_is_same_coordinator(struct ieee802154_coord_desc *a,
> > +                             struct ieee802154_coord_desc *b)
> > +{
> > +       if (a->addr->pan_id != b->addr->pan_id)
> > +               return false;
> > +
> > +       if (a->addr->mode != b->addr->mode)
> > +               return false;
> > +
> > +       if (a->addr->mode == IEEE802154_ADDR_SHORT &&
> > +           a->addr->short_addr == b->addr->short_addr)
> > +               return true;
> > +       else if (a->addr->mode == IEEE802154_ADDR_LONG &&
> > +                a->addr->extended_addr == b->addr->extended_addr)
> > +               return true;
> > +
> > +       return false;  
> 
> semantic is a little bit different, can we use "ieee802154_addr_equal()" here?

No problem, I will.

Thanks,
Miquèl