From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:52060 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726297AbeHWVOH (ORCPT ); Thu, 23 Aug 2018 17:14:07 -0400 Subject: Re: [RFC 1/3 net] lorawan: Add LoRaWAN class module References: From: Randy Dunlap Message-ID: <30b75248-7589-fc98-819f-2b68844522f1@infradead.org> Date: Thu, 23 Aug 2018 10:43:10 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-wpan-owner@vger.kernel.org List-ID: To: Jian-Hong Pan , =?UTF-8?Q?Andreas_F=c3=a4rber?= , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jiri Pirko , Marcel Holtmann , "David S. Miller" , Matthias Brugger , Janus Piwek , =?UTF-8?Q?Michael_R=c3=b6der?= , Dollar Chen , Ken Yu , =?UTF-8?Q?Konstantin_B=c3=b6hm?= , Jan Jongboom , Jon Ortego , "contact@snootlab.com" , Ben Whitten , Brian Ray , lora@globalsat.com.tw, Alexander Graf , =?UTF-8?Q?Michal_Kube=c4=8dek?= , Rob Herring , devicetree@vger.kernel.org, Steve deRosier , Mark Brown , linux-spi@vger.kernel.org, Pieter ROBYNS , Hasnain Virk , linux-wpan - ML , Stefan Schmidt , Daniele Comel , shess@hessware.de, Xue Liu Hi, On 08/23/2018 10:15 AM, Jian-Hong Pan wrote: > diff --git a/net/maclorawan/Kconfig b/net/maclorawan/Kconfig > new file mode 100644 > index 000000000000..741992b059c6 > --- /dev/null > +++ b/net/maclorawan/Kconfig > @@ -0,0 +1,14 @@ > +config LORAWAN > + tristate "MAC layer of LoRaWAN Network support" > + select CRYPTO > + select CRYPTO_CMAC > + select CRYPTO_CBC > + select CRYPTO_AES > + ---help--- > + LoRaWAN defines a low data rate, low power and long range wireless > + wide area networks. It was designed to organise networks of sensors, > + switches and actuators, etc automation devices. It could operate as > + multiple kilometers wide. There are several things that I would change. How about this instead? LoRaWAN defines low data rate, low power and long range wireless wide area networks. It was designed to organise networks of automation devices, such as sensors, switches and actuators. It can operate multiple kilometers wide. > + > + Say Y here to compile LoRaWAN support into the kernel or say M to > + compile it as modules. -- ~Randy