From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f68.google.com ([209.85.218.68]:44774 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726268AbeHXTdv (ORCPT ); Fri, 24 Aug 2018 15:33:51 -0400 Received: by mail-oi0-f68.google.com with SMTP id l82-v6so10527594oih.11 for ; Fri, 24 Aug 2018 08:58:35 -0700 (PDT) MIME-Version: 1.0 References: <30b75248-7589-fc98-819f-2b68844522f1@infradead.org> In-Reply-To: <30b75248-7589-fc98-819f-2b68844522f1@infradead.org> From: Jian-Hong Pan Date: Fri, 24 Aug 2018 23:58:29 +0800 Message-ID: Subject: Re: [RFC 1/3 net] lorawan: Add LoRaWAN class module Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-wpan-owner@vger.kernel.org List-ID: To: rdunlap@infradead.org Cc: =?UTF-8?Q?Andreas_F=C3=A4rber?= , netdev@vger.kernel.org, ", "linux-kernel@vger.kernel.org>," , Jiri Pirko , Marcel Holtmann , "David S. Miller" , Matthias Brugger , Janus Piwek , =?UTF-8?Q?Michael_R=C3=B6der?= , Dollar Chen , Ken Yu , =?UTF-8?Q?Konstantin_B=C3=B6hm?= , Jan Jongboom , Jon Ortego , "linux-kernel@vger.kernel.org>," , Ben Whitten , Brian Ray , lora@globalsat.com.tw, Alexander Graf , =?UTF-8?Q?Michal_Kube=C4=8Dek?= , Rob Herring , devicetree@vger.kernel.org, Steve deRosier , Mark Brown , linux-spi@vger.kernel.org, Pieter ROBYNS , Hasnain Virk , linux-wpan - ML , Stefan Schmidt , Daniele Comel , shess@hessware.de, Xue Liu Randy Dunlap =E6=96=BC 2018=E5=B9=B48=E6=9C=8824=E6= =97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8A=E5=8D=881:43=E5=AF=AB=E9=81=93=EF=BC=9A > > Hi, > > On 08/23/2018 10:15 AM, Jian-Hong Pan wrote: > > diff --git a/net/maclorawan/Kconfig b/net/maclorawan/Kconfig > > new file mode 100644 > > index 000000000000..741992b059c6 > > --- /dev/null > > +++ b/net/maclorawan/Kconfig > > @@ -0,0 +1,14 @@ > > +config LORAWAN > > + tristate "MAC layer of LoRaWAN Network support" > > + select CRYPTO > > + select CRYPTO_CMAC > > + select CRYPTO_CBC > > + select CRYPTO_AES > > + ---help--- > > + LoRaWAN defines a low data rate, low power and long range wirel= ess > > + wide area networks. It was designed to organise networks of sen= sors, > > + switches and actuators, etc automation devices. It could opera= te as > > + multiple kilometers wide. > > There are several things that I would change. How about this instead? > > > LoRaWAN defines low data rate, low power and long range wireles= s > wide area networks. It was designed to organise networks of aut= omation > devices, such as sensors, switches and actuators. It can operat= e > multiple kilometers wide. That becomes better! Thank you > > + > > + Say Y here to compile LoRaWAN support into the kernel or say M = to > > + compile it as modules. > > > -- > ~Randy